Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequoia-wot: init at 0.11.0 #313490

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

Cryolitia
Copy link
Member

@Cryolitia Cryolitia commented May 21, 2024

Description of changes

https://gitlab.com/sequoia-pgp/sequoia-wot

A Rust library for authenticating bindings between User IDs and certificates using OpenPGP's web of trust. This library is designed around OpenPGP's data structures, but it does not require OpenPGP data. Instead, it is possible to manually describe a web of trust.

This crate also includes a CLI tool, sq-wot, for authenticating bindings and exploring a web of trust.

An official introduce article here: https://sequoia-pgp.org/blog/2023/03/29/202303-pretty-graphics-for-the-web-of-trust/

Thanks for review!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/se/sequoia-wot/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/se/sequoia-wot/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/se/sequoia-wot/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/se/sequoia-wot/package.nix Show resolved Hide resolved
@doronbehar
Copy link
Contributor

I saw this error on ofborg's Darwin build attempt:

tmp/nix-build-sequoia-wot-0.11.0.drv-0/source/target/x86_64-apple-darwin/release/deps/sq_wot_audit_data.o" "-Wl,-u,_AUDITABLE_VERSION_INFO"
  = note: ld: framework not found SystemConfiguration
          clang-16: error: linker command failed with exit code 1 (use -v to see invocation)

So I pushed an attempt to fix it.

@doronbehar
Copy link
Contributor

I also removed libclang from the buildInputs, because it is not really required if you also include rustPlatform.bingenHook.

@doronbehar
Copy link
Contributor

nix-init is pretty good at guessing buildInputs of rust packages apparently.

@Cryolitia
Copy link
Member Author

Should I sign the commit and re-push? Or I could just waiting, doing nothing needed.

@doronbehar
Copy link
Contributor

Should I sign the commit and re-push? Or I could just waiting, doing nothing needed.

I didn't mean to ask you to do anything, I only shared what I did, because it's hard to tell the difference with all of those force pushes. As for the signing, it is up to you - for Nixpkgs and for me it doesn't matter if you sign it or not. Force pushing now again will disrupt CI once more so consider that as well.

@Cryolitia
Copy link
Member Author

Ok thx

Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, OK to merge as far as I'm concerned, which I'll happily do once my question is answered

pkgs/by-name/se/sequoia-wot/package.nix Show resolved Hide resolved
Co-authored-by: Doron Behar <doron.behar@gmail.com>
@doronbehar
Copy link
Contributor

CI was completely green before, so I won't wait for darwin CI.

@doronbehar doronbehar merged commit 03d792f into NixOS:master May 26, 2024
23 of 24 checks passed
@doronbehar
Copy link
Contributor

Thanks @Cryolitia for contributing this package 👍 .

@Cryolitia Cryolitia deleted the sequoia-wot branch May 26, 2024 04:20
@nbraud
Copy link
Contributor

nbraud commented May 26, 2024

Thanks, @Cryolitia and @doronbehar :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants