python3Packages.import-expression: 1.1.4 -> 1.1.5

[StarrFox]

Description of changes

updates version to 1.1.5, the main change this version is that tests are included in the pypi source dists so we don't need to pull from github anymore

the patch is also no longer needed as it was merged in this version

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[itslychee]

Thanks for the PR, if you wouldn't mind, could you update the nativeBuildInputs and propagatedBuildInputs field names to build-system and dependencies respectively, the Python wrapper was recently updated to have clearer naming on where deps go.

https://nixos.org/manual/nixpkgs/unstable/#buildpythonpackage-function
#271597

[StarrFox]

Thanks for the PR, if you wouldn't mind, could you update the nativeBuildInputs and propagatedBuildInputs field names to build-system and dependencies respectively, the Python wrapper was recently updated to have clearer naming on where deps go.

https://nixos.org/manual/nixpkgs/unstable/#buildpythonpackage-function #271597

done

[itslychee]

Thank you, if you could rewrite the commit message to be like python3Packages.import-expression: update legacy attributes to follow the commit conventions that'd be wonderful!

[itslychee]

silly bot

[tomberek]

Result of nixpkgs-review pr 314735 run on x86_64-linux 1

4 packages failed to build:

• python312Packages.import-expression
• python312Packages.import-expression.dist
• python312Packages.jishaku
• python312Packages.jishaku.dist

4 packages built:

• python311Packages.import-expression
• python311Packages.import-expression.dist
• python311Packages.jishaku
• python311Packages.jishaku.dist

[tomberek]

Might want something like:

diff --git a/pkgs/development/python-modules/import-expression/default.nix b/pkgs/development/python-modules/import-expression/default.nix
index 3407aa277152..34f49401996d 100644
--- a/pkgs/development/python-modules/import-expression/default.nix
+++ b/pkgs/development/python-modules/import-expression/default.nix
@@ -6,6 +6,7 @@
   pytestCheckHook,
   astunparse,
   setuptools,
+  pythonAtLeast,
 }:
 buildPythonPackage rec {
   pname = "import-expression";
@@ -36,6 +37,7 @@ buildPythonPackage rec {
       psfl
     ];
     mainProgram = "import-expression";
+    broken = pythonAtLeast "3.12";
     maintainers = with lib.maintainers; [ lychee ];
   };
 }

or fix the issue

[tomberek]

merging, as this doesn't make the breakage worse, but still recommend addressing python312

[StarrFox]

Might want something like:

diff --git a/pkgs/development/python-modules/import-expression/default.nix b/pkgs/development/python-modules/import-expression/default.nix
index 3407aa277152..34f49401996d 100644
--- a/pkgs/development/python-modules/import-expression/default.nix
+++ b/pkgs/development/python-modules/import-expression/default.nix
@@ -6,6 +6,7 @@
   pytestCheckHook,
   astunparse,
   setuptools,
+  pythonAtLeast,
 }:
 buildPythonPackage rec {
   pname = "import-expression";
@@ -36,6 +37,7 @@ buildPythonPackage rec {
       psfl
     ];
     mainProgram = "import-expression";
+    broken = pythonAtLeast "3.12";
     maintainers = with lib.maintainers; [ lychee ];
   };
 }

or fix the issue

ioistired/import-expression@e1b5c76

new version of package which fixes the 3.12 issue out now

[itslychee]

Not really sure why they bumped the major version as there doesn't seem to be anything breaking, but regardless I think it's okay to bump the package's major version, unsure of what the policy is around that.