-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: remove unused occurence of fetchFromGitHub argument #314910
Conversation
fb8a748
to
e265cd2
Compare
Result of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 rebuilds!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this gets merged, it should probably be added to .git-blame-ignore-revs
, ty for noticing and fixing this :D
Maybe the whole list of commits from #313981 should gets git blame ignored. In that case, it might be better to deal with it once the whole issue is done? |
I don't see why they would need to be tied together to be honest, i think it's much better to just get it done as it comes. Let's move that discussion to the issue thou, I don't think it should block this. |
Description of changes
#313981
These files were left unchanged due to them calling other files with the
fetchFromGitHub
arg.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.