Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove unused occurence of fetchFromGitHub argument #314910

Merged
merged 1 commit into from
May 30, 2024

Conversation

isabelroses
Copy link
Member

Description of changes

#313981

These files were left unchanged due to them calling other files with the fetchFromGitHub arg.

"pkgs/servers/foundationdb/default.nix"
"pkgs/games/fteqw/default.nix"
"pkgs/development/compilers/zig/0.11.nix"
"pkgs/development/compilers/zig/0.12.nix"
"pkgs/development/compilers/zig/0.10.nix"

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 26, 2024
@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 26, 2024
@Sigmanificient
Copy link
Member

Result of nixpkgs-review pr 314910 run on x86_64-linux 1

Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 rebuilds!

@isabelroses isabelroses added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 26, 2024
@isabelroses isabelroses removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label May 27, 2024
@isabelroses isabelroses added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label May 27, 2024
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this gets merged, it should probably be added to .git-blame-ignore-revs, ty for noticing and fixing this :D

@Sigmanificient
Copy link
Member

Sigmanificient commented May 29, 2024

After this gets merged, it should probably be added to .git-blame-ignore-revs, ty for noticing and fixing this :D

Maybe the whole list of commits from #313981 should gets git blame ignored. In that case, it might be better to deal with it once the whole issue is done?

@cafkafk
Copy link
Member

cafkafk commented May 30, 2024

After this gets merged, it should probably be added to .git-blame-ignore-revs, ty for noticing and fixing this :D

Maybe the whole list of commits from #313981 should gets git blame ignored. In that case, it might be better to deal with it once the whole issue is done?

I don't see why they would need to be tied together to be honest, i think it's much better to just get it done as it comes. Let's move that discussion to the issue thou, I don't think it should block this.

@ehmry ehmry merged commit 63aceac into NixOS:master May 30, 2024
24 checks passed
@isabelroses isabelroses deleted the deadnix/fetchFromGitHub branch June 10, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: emacs Text editor 6.topic: erlang 6.topic: julia 6.topic: nim Nim programing language 6.topic: ocaml 6.topic: python 6.topic: ruby 6.topic: vim 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants