cabal2nix: Fix for justStaticExecutables #315464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
requested review from
sternenseemann,
maralorn and
ncfavier
as code owners
9999years
force-pushed
the
cabal2nix-juststaticexecutables
branch
from
61ed287 to
e2a06bb
Compare
|
I think we should move these overrides into the |
Remove references to `hpack` and `distribution-nixpkgs` paths so that `cabal2nix` can build on macOS. See: NixOS#304352
9999years
force-pushed
the
cabal2nix-juststaticexecutables
branch
from
e2a06bb to
67bb4e1
Compare
|
Done, PTAL |
ofborg
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove references to
hpackanddistribution-nixpkgspaths so thatcabal2nixcan build on macOS.See: #304352
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.