pnpm.fetchDeps: error if lockfile version has a mismatch #317739
Conversation
SuperSandro2000
force-pushed
the
pnpm-fetch-deps
branch
from
4b6584c
to
a202382
Compare
SuperSandro2000
changed the title
| # Don't force us to use an older version of pnpm. A newer version probably generates another FOD though. | ||
| jq --sort-keys "del(.. | .packageManager?)" package.json | sponge package.json | ||
|
|
There was a problem hiding this comment.
In a similar vein as Python relaxDepsHook, this should probably be a flag that's off by default.
ofborg
bot
added
10.rebuild-darwin: 0
SuperSandro2000
force-pushed
the
pnpm-fetch-deps
branch
from
a202382
to
e376b03
Compare
SuperSandro2000
requested review from
lilyinstarlight and
winterqt
as code owners
SuperSandro2000
force-pushed
the
pnpm-fetch-deps
branch
from
27583fd
to
8aa3b07
Compare
SuperSandro2000
changed the title
|
I've removed |
| ]; | ||
|
|
||
| installPhase = '' | ||
| runHook preInstall | ||
|
|
||
| lockfileVersion="$(yq -r .lockfileVersion pnpm-lock.yaml)" | ||
| if [[ ''${lockfileVersion:0:1} -gt ${lib.versions.major pnpm.version} ]]; then | ||
| echo "ERROR: lockfileVersion in pnpm-lock.yaml is to new for the provided pnpm version ${lib.versions.major pnpm.version}!" |
There was a problem hiding this comment.
I started with some corrections and improvements, and continued with a suggested way to overcome this check.
| echo "ERROR: lockfileVersion in pnpm-lock.yaml is to new for the provided pnpm version ${lib.versions.major pnpm.version}!" | |
| echo "ERROR: lockfileVersion $lockfileVersion in pnpm-lock.yaml is" \ | |
| "too new for the provided pnpm version" \ | |
| "${lib.versions.major pnpm.version}! Set" \ | |
| "pnpmDontCheckLockfileVersion=true to avoid this error if you're" \ | |
| "sure it won't cause other issues" >&2 |
There was a problem hiding this comment.
That won't do anything, as pnpm will fail with a rather cryptic error message anyway.
Can you share more details about the issue that made you remove it? |
It needed to be in mkDerivation and inside fetchDeps and got more complicated the more deeply I tested it. |
SuperSandro2000
force-pushed
the
pnpm-fetch-deps
branch
from
8aa3b07
to
7a1cd1f
Compare
wegank
added
the
12.approvals: 1
Description of changes
Tested while updating youtube-music
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.