Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modrinth-app: use pnpm.fetchDeps #318117

Closed
wants to merge 2 commits into from
Closed

modrinth-app: use pnpm.fetchDeps #318117

wants to merge 2 commits into from

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jun 7, 2024

Description of changes

Adopts the new tooling from #290715
Follows advice from #312345

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 7, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@getchoo getchoo force-pushed the pkgs/modrinth-app/pnpmFetchDeps branch from b5cb4ed to b5d7392 Compare July 12, 2024 04:01
@getchoo getchoo removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 12, 2024
@getchoo getchoo mentioned this pull request Aug 19, 2024
Merged
13 tasks
@gepbird gepbird added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 2, 2024
SuperSandro2000
SuperSandro2000 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@getchoo
Copy link
Member Author

getchoo commented Sep 2, 2024

Sorry I forgot to close this. It's included in #336494 now without merge conflicts

@getchoo getchoo closed this Sep 2, 2024
@getchoo getchoo deleted the pkgs/modrinth-app/pnpmFetchDeps branch September 2, 2024 14:08
@getchoo getchoo mentioned this pull request Sep 2, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@getchoo @SuperSandro2000 @wegank @gepbird