Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.push-notify-apn: unbroken #319890

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

mpscholten
Copy link
Contributor

Description of changes

I took over maintainership of this package a while ago and fixed the build errors in the latest hackage release

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

I took over maintainership of this package a while ago and fixed the
build errors in the latest hackage release
@maralorn
Copy link
Member

btw. you might be interested in registering as a maintainer for some haskell packages. Have a look at the maintainers section in the Haskell main.yaml file if that is the case.

@maralorn maralorn merged commit 180957a into NixOS:haskell-updates Jun 17, 2024
29 checks passed
@maralorn
Copy link
Member

thx!

@mpscholten mpscholten deleted the push-notify-apn-unbroken branch June 17, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants