Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textidote: init at 0.8.3 #321054

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

magneticflux-
Copy link
Contributor

@magneticflux- magneticflux- commented Jun 19, 2024

Description of changes

Closes #269754

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 19, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 19, 2024
@magneticflux-
Copy link
Contributor Author

@Sntx626 could you test to make sure your use-case works? I've tested that it works for the TeXiFy IDEA plugin on my own documents.

@Sntx626
Copy link

Sntx626 commented Jun 19, 2024

Build & used on:

  • aarch64-linux
  • x86_64-linux

@Sntx626 could you test to make sure your use-case works? I've tested that it works for the TeXiFy IDEA plugin on my own documents.

Yes, it works for my use-case! At the moment I'm running a watcher script that re-runs textidote whenever I update my project.

@magneticflux-
Copy link
Contributor Author

To anyone more experienced at this: is this the best way to go about tracking the dozen or so dependencies? Unfortunately this Ant build isn't much better than a Makefile so there's no lockfile to track dependencies like with NPM, Cargo, Maven, or Gradle. I've never messed around with "manually" creating a Fixed Output Derivation before, but it seems kinda like how the Maven wrapper is built (except in this case our dependencies are downloaded manually and mixed in with the source code 🙄).

@magneticflux-
Copy link
Contributor Author

Thanks for the help! I copied an old Java package and built off of that, so some old-style code crept in without me knowing the difference.

Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution; some feedback below:

pkgs/by-name/te/textidote/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/textidote/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/textidote/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/textidote/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/textidote/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/textidote/package.nix Outdated Show resolved Hide resolved
@magneticflux- magneticflux- force-pushed the textidote branch 2 times, most recently from a262c3d to 17e40fa Compare August 10, 2024 20:20
magneticflux- and others added 2 commits August 10, 2024 15:33
Co-authored-by: éclairevoyant <848000+eclairevoyant@users.noreply.github.com>
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024
Comment on lines +65 to +70
nativeBuildInputs = [
ant
jdk
makeWrapper
stripJavaArchivesHook
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [
ant
jdk
makeWrapper
stripJavaArchivesHook
];
nativeBuildInputs = [
ant
makeWrapper
stripJavaArchivesHook
];
buildInputs = [
jdk
];

Otherwise it doesn't build with strictDeps = true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: TeXtidote
6 participants