-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
textidote: init at 0.8.3 #321054
base: master
Are you sure you want to change the base?
textidote: init at 0.8.3 #321054
Conversation
@Sntx626 could you test to make sure your use-case works? I've tested that it works for the TeXiFy IDEA plugin on my own documents. |
Build & used on:
Yes, it works for my use-case! At the moment I'm running a watcher script that re-runs textidote whenever I update my project. |
To anyone more experienced at this: is this the best way to go about tracking the dozen or so dependencies? Unfortunately this Ant build isn't much better than a Makefile so there's no lockfile to track dependencies like with NPM, Cargo, Maven, or Gradle. I've never messed around with "manually" creating a Fixed Output Derivation before, but it seems kinda like how the Maven wrapper is built (except in this case our dependencies are downloaded manually and mixed in with the source code 🙄). |
Thanks for the help! I copied an old Java package and built off of that, so some old-style code crept in without me knowing the difference. |
45cf220
to
6bf1fcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution; some feedback below:
a262c3d
to
17e40fa
Compare
Co-authored-by: éclairevoyant <848000+eclairevoyant@users.noreply.github.com> Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
17e40fa
to
275d289
Compare
nativeBuildInputs = [ | ||
ant | ||
jdk | ||
makeWrapper | ||
stripJavaArchivesHook | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ | |
ant | |
jdk | |
makeWrapper | |
stripJavaArchivesHook | |
]; | |
nativeBuildInputs = [ | |
ant | |
makeWrapper | |
stripJavaArchivesHook | |
]; | |
buildInputs = [ | |
jdk | |
]; |
Otherwise it doesn't build with strictDeps = true.
Description of changes
Closes #269754
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.