Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hound: convert to use freeform type #322508

Merged
merged 5 commits into from
Jun 28, 2024
Merged

hound: convert to use freeform type #322508

merged 5 commits into from
Jun 28, 2024

Conversation

MarcelCoding
Copy link
Member

Description of changes

  • Migrate plain text configuration to structured attr set.
  • added build time configuration check.
  • cleanup services.hound.enable

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 25, 2024
@ofborg ofborg bot requested review from grahamc and SuperSandro2000 June 25, 2024 23:29
@MarcelCoding MarcelCoding mentioned this pull request Jun 26, 2024
Open
11 tasks
@MarcelCoding MarcelCoding force-pushed the hound branch 2 times, most recently from e6196d4 to 3c334d5 Compare June 26, 2024 17:22
@ofborg ofborg bot requested a review from SuperSandro2000 June 26, 2024 17:35
@ofborg ofborg bot requested a review from SuperSandro2000 June 26, 2024 22:16
@SuperSandro2000 SuperSandro2000 changed the title hound: cherry-pick conf check flag hound: convert to use freeform type Jun 27, 2024
@SuperSandro2000 SuperSandro2000 merged commit 0cbf178 into NixOS:master Jun 28, 2024
25 checks passed
@MarcelCoding MarcelCoding deleted the hound branch June 29, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcelCoding @SuperSandro2000