-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binwalk, diffoscope: update after Python 3.12 #325623
Conversation
@trofi fyi |
Is that behavioural change in |
I was quite surprised to see it as well. You can see from the patch what the detected differences are. I checked out upstream (https://salsa.debian.org/reproducible-builds/diffoscope) locally and ran
Then, with this PR (note the Python 3.12 in the derivation name):
What I don't understand is how there were ever two emitted items. Master appears to have 10 as well. |
def test_listing(comparison): | ||
differences = comparison.details | ||
- assert comparison.comments == ["comprises of 2 embedded members"] | ||
+ assert comparison.comments == ["comprises of 10 embedded members"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this by design i.e. a number that we can rely on to continue to be 10? or might this change in the future?
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/error-nose-1-3-7-not-supported-for-interpreter-python3-12/48703/22 |
Please rebase. (And whatever new improvement/fix that isn't in 326295 can be integrated.) |
Both binwalk and diffoscope appear to build on current |
But there’s nothing to rebase now; #326295 replaces this. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Quite so. |
Description of changes
binwalk
uses bothimp
andnose
which are not supported on Python 3.12. See fix #667 (Python 3.12 compatibility) ReFirmLabs/binwalk#668diffoscope
unit test for binwalk now sees more cpio binaries in its test.related to #325657 (comment)
cc @Mag1cByt3s
Result of
nixpkgs-review
run on x86_64-linux 115 packages built:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)