make-disk-image: Support creating EFI images #32618
Conversation
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
Very cool! Main nitpick is that I'd be inclined to just have a three-valued option for a parameter called A little sad about the |
Sounds like a good idea. I will implement that.
In theory you can do tricks like https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/installer/cd-dvd/sd-image.nix#L99 but in the case of KVM actually being available that ends up being a net loss since it requires |
dezgeg
force-pushed
the
makediskimage-efi
branch
from
bb8e957 to
7b115c3
Compare
|
Finally updated to the three-value enum. Need to do some testing that I didn't break something else. Edit: At least the latest variant can build the OVA & EC2 image. |
- Add a new parameter `imageType` that can specify either "efi" or "legacy" (the default which should see no change in behaviour by this patch). - EFI images get a GPT partition table (instead of msdos) with a mandatory ESP partition (so we add an assert that `partitioned` is true). - Use the partx tool from util-linux to determine exact start + size of the root partition. This is required because GPT stores a secondary partition table at the end of the disk, so we can't just have mkfs.ext4 create the filesystem until the end of the disk. - (Unrelated to any EFI changes) Since we're depending on the `-E offset=X` option to mkfs which is only supported by e2fsprogs, disallow any attempts of creating partitioned disk images where the root filesystem is not ext4.
dezgeg
force-pushed
the
makediskimage-efi
branch
from
7b115c3 to
2651fac
Compare
|
@copumpkin how does this look now? |
|
Looks good, sorry for the delayed response! |
This adds EFI support to make-disk-image. That is, for
imageType == "efi"the image gets a GPT partition table instead of the usual DOS partition table, and a FAT32 ESP partition is created in addition to the root partition.With a bunch of butchering of amazon-image.nix in master...dezgeg:aarch64-makediskimage I end up with a booting AArch64 image (using EFI GRUB) that can boot in QEMU. Still need to clean up & split those into it's own files but these changes should be ready for review now.
@copumpkin