wkhtmltopdf: unbreak package #327641
wkhtmltopdf: unbreak package #327641
Conversation
|
Result of 5 packages built:
|
| runHook preUnpack | ||
|
|
||
| mkdir pkg | ||
| dpkg-deb -x $src pkg |
There was a problem hiding this comment.
Does fetchzip decompress it? idk
There was a problem hiding this comment.
Technally yes, there is one package doing it, pkgs/by-name/te/tetrio-desktop/package.nix. All of the others are using fetchurl.
I prefer using fetchurl as the hash is on the content and can be easily calculated separately.
zimbatm
force-pushed
the
default-wkhtmktopdf-bin
branch
from
1178c6c to
b8d5249
Compare
wkhtmltopdf is a bit cursed. 1. It needs a specially patched version of QT to work. 2. It doesn't build currently. 3. Upstream repos are archived. 4. It depends on insecure dependencies. In the mid term this dependency should be removed, but it's still a hard dependency for: * bookstack * monica * odoo (ref odoo/odoo#86501) * snipe-it Instead of spending time to fix the build issues, use the -bin version in the meantime.
Use the latest release before the project was archived. Removes dependency on openssl_1_1 which is marked as insecure, so this package should be built by Hydra once again.
zimbatm
force-pushed
the
default-wkhtmktopdf-bin
branch
from
b8d5249 to
a4673b4
Compare
| @@ -14433,6 +14433,7 @@ with pkgs; | |||
| wireguard-go = callPackage ../tools/networking/wireguard-go { }; | |||
|
|
|||
| wkhtmltopdf-bin = callPackage ../tools/graphics/wkhtmltopdf-bin { }; | |||
| wkhtmltopdf = wkhtmltopdf-bin; | |||
There was a problem hiding this comment.
hydra doesn't allow aliases to be passed to packages.
we could rename all the inputs, or keep this manual alias here.
|
yes, I have some follow-up PRs and a blog post coming up. Definitely not production ready. |
|
@zimbatm there's this that might help? https://github.com/novacode-nl/nix-odoo |
|
I've seen it; it's more for a dev setup than to deploy Odoo. |
Description of changes
Some strategic changes to allow the package to be built again.
Motivation: Odoo depends on this package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.