Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove unused lib (and other) arguments #327801

Merged
merged 1 commit into from
Jul 26, 2024
Merged

treewide: remove unused lib (and other) arguments #327801

merged 1 commit into from
Jul 26, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim 6.topic: ocaml 6.topic: fetch 6.topic: lua 6.topic: module system About "NixOS" module system internals 6.topic: lib The Nixpkgs function library 6.topic: zig labels Jul 17, 2024
@Sigmanificient Sigmanificient force-pushed the unused-args-lib branch 11 times, most recently from 9153219 to 03cdfae Compare July 17, 2024 18:08
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 17, 2024
@Sigmanificient Sigmanificient marked this pull request as ready for review July 18, 2024 12:13
@Aleksanaa Aleksanaa added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2024
@Sigmanificient Sigmanificient removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2024
jopejoe1
jopejoe1 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!

@roberth
Copy link
Member

roberth commented Jul 26, 2024

Unused arguments are observable with functionArgs so we have reason to be careful about this in the lib tests, but these parameters are genuinely unused. 👍

@roberth roberth merged commit 433a0e6 into NixOS:master Jul 26, 2024
24 checks passed
@Sigmanificient Sigmanificient deleted the unused-args-lib branch July 26, 2024 13:23
imincik added a commit to imincik/geospatial-nix that referenced this pull request Aug 1, 2024
@imincik
qgis+qgis-ltr: remove unused lib
194150e 
Nixpkgs PR:
NixOS/nixpkgs#327801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jopejoe1 jopejoe1 jopejoe1 approved these changes

@adamcstephens adamcstephens Awaiting requested review from adamcstephens

@figsoda figsoda Awaiting requested review from figsoda

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@teto teto Awaiting requested review from teto

@K900 K900 Awaiting requested review from K900

@NickCao NickCao Awaiting requested review from NickCao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

@jbedo jbedo Awaiting requested review from jbedo

@natsukium natsukium Awaiting requested review from natsukium

@h7x4 h7x4 Awaiting requested review from h7x4

@infinisil infinisil Awaiting requested review from infinisil

@roberth roberth Awaiting requested review from roberth

Assignees
No one assigned
Labels
6.topic: fetch 6.topic: lib The Nixpkgs function library 6.topic: lua 6.topic: module system About "NixOS" module system internals 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml 6.topic: python 6.topic: qt/kde 6.topic: vim 6.topic: zig 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sigmanificient @roberth @jopejoe1 @Aleksanaa