mingtest: init at 0.1.9

[lutzberger]

Description of changes

https://github.com/craflin/mingtest

Things done

add mingtest in nix-expression in pkgs/development/libraries

• Built on platform(s)
  • [ x] x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[jackyliu16]

AFAICT, this file is still not formatted according to the style specified by Nix RFC 166, which is a style that all .nix files in Nixpkgs must adhere to.

To ensure that the Nix expression in this file follows the Nix RFC 116, please format it with pkgs.nixfmt-rfc-style:
$ nix run .#nixfmt-rfc-style -- pkgs/<your file>
Or if you do not use flakes,
$ NIX_PATH="nixpkgs=$PWD" nix-shell -p nixfmt-rfc-style --run "nixfmt pkgs/<your file>"

[Aleksanaa]

It appears to be a dynamic link library that can be used by gtest, but it contains the gtest header itself. Maybe we should use the gtest header in nixpkgs instead, so that it works with our gtest.

[jackyliu16]

BTW, You may want to squash those commit update the version into one (and remove you update rev operation)
Nixpkgs normally follow a specify release(if release existed), rather than a commit.

[lutzberger]

BTW, You may want to squash those commit update the version into one (and remove you update rev operation) Nixpkgs normally follow a specify release(if release existed), rather than a commit.

How to do it? With "git rebase -i" and than "push -f"?

[jackyliu16]

BTW, You may want to squash those commit update the version into one (and remove you update rev operation) Nixpkgs normally follow a specify release(if release existed), rather than a commit.

How to do it? With "git rebase -i" and than "push -f"?

normally, we recommand to do following operation, but I couldn't guarantee results, please backup all of your file and do it.

1. add a new commit to fixup incorrect version (-4），I not sure if done it.
2. using git log to find the previous commit before your commit.
3. use git bash -i to go into the rebase CLI.
4. base on the note to change the first words from pick to others ( for the commit you want to operate ) [ which right now should only contains two commit, one for add maintainers and one for add packages.
   (squash commit will merge two commit into one)
5. before you makesure everything is correct use git push --force to repush your current branch into here.

[lutzberger]

Why this pull request is still not merged? Is still something missing?

[eclairevoyant]

Well it doesn't eval, that's certainly one reason.
You'll have to add yourself as a maintainer, separately, in the first commit (maintainers: add lutzberger), to the full maintainers list.

Also, the contents of the commits don't really match the messages, anything touching the mingtest package should be in the mingtest init commit.

If you need a reference, you can look at other merged, init PRs from first-time contributors: https://github.com/NixOS/nixpkgs/issues?q=label%3A%2212.+first-time+contribution%22+is%3Amerged+in%3Atitle+init

[eclairevoyant]

Also, Aleksanaa's comment wasn't addressed yet; please correct accordingly.

[lutzberger]

Through rebasing I got now 4 commits into this fork, but it should only be 2. I have not changed anything in the fist 2 commits from other people. I don't know now how to remove that 2 commits from my fork, without removing from git?

[lutzberger]

Found the first 2 commits as duplicate. Could remove them with git rebase.

[lutzberger]

It appears to be a dynamic link library that can be used by gtest, but it contains the gtest header itself. Maybe we should use the gtest header in nixpkgs instead, so that it works with our gtest.

It is a currently a static library.

[eclairevoyant]

Please squash the last commit into the init commit

[lutzberger]

I guess the automerge is waiting for the queued check to be executed. Why it is so long time queued?

[eclairevoyant]

There's no automerge, and darwin builders take 2+ days usually

[lutzberger]

Thanks for the info