Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buzztrax: fix build with clang 16 #328591

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

reckenrode
Copy link
Contributor

Description of changes

After the libxml2 2.12 update, buzztrax fails to build due to an incompatible function pointer error. This error has not been fixed upstream, so just suppress it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

After the libxml2 2.12 update, buzztrax fails to build due to an incompatible function pointer error. This error has not been fixed upstream, so just suppress it.
@ofborg ofborg bot requested a review from bendlas July 20, 2024 06:04
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 20, 2024
Copy link
Contributor

@bendlas bendlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct in assuming that this is hitting darwin users?

@reckenrode
Copy link
Contributor Author

Am I correct in assuming that this is hitting darwin users?

They would be the primarily affected users since Darwin uses clang by default. I encountered the issue while running nixpkgs-review on #328586.

@reckenrode reckenrode merged commit 8c56c9b into NixOS:master Jul 23, 2024
29 checks passed
@reckenrode reckenrode deleted the buzztrax-fixes branch July 23, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants