otadump: init at 0.1.2 #329129
Merged
otadump: init at 0.1.2 #329129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
|
@Aleksanaa You're the maintainer of payload-dumper-go. Can you help review this PR? |
FliegendeWurst
previously requested changes
Nov 9, 2024
Aleksanaa
reviewed
Dec 8, 2024
ofborg
bot
added
8.has: package (new)
Aleksanaa
reviewed
Dec 10, 2024
Aleksanaa
approved these changes
Dec 11, 2024
|
@ofborg build otadump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It helps to extract partitions from Android OTA files (payload.bin) like payload-dumper-go.
I removed the
staticfeature of the rust-lzma crate since the author used it to build universal binaries using musl.The binary works in
nix-shell --pure -ptoo but I'm hoping someone with more experience can tell me if lzma needs to be added to propagatedBuildInputs or something.https://github.com/crazystylus/otadump
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.