Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aicommit2: init at 2.1.5 #329349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ByteSudoer
Copy link
Contributor

Description of changes

Project description
A Reactive CLI that generates git commit messages with Ollama, ChatGPT, Gemini, Claude, Mistral and other AI.
Conventional Commits and bitmoji.dev aware.

Metadata

Closes #328908

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/ai/aicommit2/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ai/aicommit2/package.nix Show resolved Hide resolved
pkgs/by-name/ai/aicommit2/package.nix Outdated Show resolved Hide resolved
@techie2000
Copy link

As the original requestor, I'm enquiring if there is anything I can do help to nudge this to the next stage?

@noamsto
Copy link

noamsto commented Sep 8, 2024

@ByteSudoer
I tried this localy and it didn't really work, It doesn't discover git dir...
image

Copy link

@noamsto noamsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with the following changes, and it works!
image

pkgs/by-name/ai/aicommit2/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ai/aicommit2/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ai/aicommit2/package.nix Outdated Show resolved Hide resolved
@ByteSudoer ByteSudoer changed the title aicommit2: init at 1.12.3 aicommit2: init at 2.1.5 Oct 20, 2024
pkgs/by-name/ai/aicommit2/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024

pnpmDeps = pnpm.fetchDeps {
inherit (finalAttrs) pname version src;
hash = "sha256-y3IftcRhsDDyMZ2AE07WyY94mp0j6M6UVno7Qp8d/G8=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hash = "sha256-y3IftcRhsDDyMZ2AE07WyY94mp0j6M6UVno7Qp8d/G8=";
hash = "sha256-GaNNw+qxB493kUo6wfltBvaL67qKCHZw7vLPv9MjnPw=";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please rebase to master
#329349 (comment)

@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Dec 4, 2024
@pyrox0
Copy link
Member

pyrox0 commented Dec 8, 2024

Is there any interest in updating this PR and fixing the suggested changes?

@FliegendeWurst FliegendeWurst added 2.status: needs-changes This PR needs changes by the author and removed awaiting_changes (old Marvin label, do not use) labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: needs-changes This PR needs changes by the author 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: nodePackages.aicommit2
10 participants