Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.etebase: 0.31.6 -> 0.31.7, fix build with Python 3.12 #329671

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Jul 24, 2024

Description of changes

  • update to 0.31.7 for patches to apply
  • add patch updating cpython to 0.7.2 to fix build with Python 3.12
  • add patch updating flapigen to 0.6.1 to remove git dependency from Cargo.lock

Update to 0.31.7 and flapigen patch are needed to not vendor full Cargo.lock or big (200+ lines) patch.

Changelog 0.31.6 -> 0.31.7:
etesync/etebase-py@v0.31.6...v0.31.7

## Version 0.31.7
* Bump etebase dependency to latest

Fixes #328382 (build of etesync-dav that depends on python312Packages.etebase)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- update to 0.31.7 for patches to apply
- add patch updating cpython to 0.7.2 to fix build
with Python 3.12
- add patch updating flapigen to 0.6.1 to remove
git dependency from Cargo.lock
@ghpzin ghpzin force-pushed the python312-etebase-fix-build branch from e8a8381 to df73d2d Compare July 24, 2024 16:34
@ghpzin
Copy link
Contributor Author

ghpzin commented Jul 24, 2024

Result of nixpkgs-review pr 329671 run on x86_64-linux 1

6 packages built:
  • etesync-dav
  • etesync-dav.dist
  • python311Packages.etebase
  • python311Packages.etebase.dist
  • python312Packages.etebase
  • python312Packages.etebase.dist

@ghpzin ghpzin marked this pull request as ready for review July 24, 2024 18:42
@pbsbot
Copy link

pbsbot commented Jul 28, 2024

Result of nixpkgs-review pr 329671 run on x86_64-linux 1

6 packages built:
  • etesync-dav
  • etesync-dav.dist
  • python311Packages.etebase
  • python311Packages.etebase.dist
  • python312Packages.etebase
  • python312Packages.etebase.dist

@pbsds
Copy link
Member

pbsds commented Jul 28, 2024

@pbsds pbsds merged commit 2f87544 into NixOS:master Jul 28, 2024
22 checks passed
@ghpzin ghpzin deleted the python312-etebase-fix-build branch August 10, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python312Packages.etebase (for etesync-dav)
3 participants