tesseract: 5.3.4 -> 5.4.1 #329842
tesseract: 5.3.4 -> 5.4.1 #329842
Conversation
ofborg
bot
added
11.by: package-maintainer
|
|
||
| src = fetchFromGitHub { | ||
| owner = "tesseract-ocr"; | ||
| repo = "tesseract"; | ||
| rev = version; | ||
| sha256 = "sha256-IKxzDhSM+BPsKyQP3mADAkpRSGHs4OmdFIA+Txt084M="; | ||
| sha256 = "sha256-Yce9DVt1RJZkwN7ZlUE57eHm+cB9z7MbdFv8uCiGapo="; |
There was a problem hiding this comment.
| sha256 = "sha256-Yce9DVt1RJZkwN7ZlUE57eHm+cB9z7MbdFv8uCiGapo="; | |
| hash = "sha256-Yce9DVt1RJZkwN7ZlUE57eHm+cB9z7MbdFv8uCiGapo="; |
|
please consider adding link to Changelog and/or Diff to PR and commit message something like 3e051ce |
Thanks for the feedback, I have addressed this. Let me know if it looks how you expect. |
There was a problem hiding this comment.
It seems like OpenCL support was dropped in tesseract-ocr/tesseract#4220. Removing opencl-headers from buildInputs still builds for me.
Edit: Building with and without opencl-headers seems to produce identical binaries, except for the different out path of course.
Thanks - it built for me and was able to test and works fine without opencl-headers. Addressed, and fixed some formatting. |
|
Result of 2 packages marked as broken and skipped:
10 packages failed to build:
73 packages built:
|
The remaining failures are indirect |
|
This actually seems to break |
|
Applying the following diff fixes k2pdfopt: diff --git a/pkgs/applications/misc/k2pdfopt/default.nix b/pkgs/applications/misc/k2pdfopt/default.nix
index 32a0e31a315b..b0a8e5d17742 100644
--- a/pkgs/applications/misc/k2pdfopt/default.nix
+++ b/pkgs/applications/misc/k2pdfopt/default.nix
@@ -142,6 +142,9 @@ in stdenv.mkDerivation rec {
};
tesseract_modded = tesseract.override {
tesseractBase = tesseract.tesseractBase.overrideAttrs ({ patches ? [], ... }: {
+ pname = "tesseract-k2pdfopt";
+ version = tesseract_patch.src.rev;
+ src = tesseract_patch.src;
patches = patches ++ [ tesseract_patch ];
# Additional compilation fixes
postPatch = ''
|
wegank
added
the
12.approvals: 1
|
Converted to draft @Scrumplex . |
Description of changes
Bumps tesseract to 5.4.1.
I am also personally invested in this package, so adding myself as a maintainer.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.