-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.pygeoip: drop #330509
python3Packages.pygeoip: drop #330509
Conversation
@emilazy @natsukium Having trouble with Help would be welcome |
@mog (sopel maintainer) |
Please remove |
I added it because of:
|
4aa2c13
to
6af46d0
Compare
This seems reasonable but it’d probably be best to split out the substantive |
Result of 2 packages failed to build:3 packages built successfully:
|
I think the current hack is fine for the circular dependency, but sopel-help tests don't pass. |
I was thinking we’d probably want a standard |
We are working on separating build and runtime inputs for python packages in the future, and it will be resolved then. #272178 |
5f4744f
to
02ac5ea
Compare
Just removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ofborg build python3Packages.sopel
02ac5ea
to
0dc85bd
Compare
0dc85bd
to
e5d85eb
Compare
@ofborg build python312Packages.sopel |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.