Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pygeoip: drop #330509

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient
Copy link
Member Author

@emilazy @natsukium Having trouble with infinite recursion (sopel -> sopel-help -> sopel -> ...)

Help would be welcome

@Sigmanificient Sigmanificient changed the title python3Packages.xssr: drop python3Packages.pygeoip: drop Jul 27, 2024
@Sigmanificient
Copy link
Member Author

@mog (sopel maintainer)

@natsukium
Copy link
Member

Please remove sopel-help from sopel's dependencies, since sopel doesn't directly depend on sopel-help.
https://github.com/search?q=repo%3Asopel-irc%2Fsopel+sopel_help&type=code

@Sigmanificient
Copy link
Member Author

Please remove sopel-help from sopel's dependencies, since sopel doesn't directly depend on sopel-help. github.com/search?q=repo%3Asopel-irc%2Fsopel+sopel_help&type=code

I added it because of:

Executing pythonRuntimeDepsCheck
Checking runtime dependencies for sopel-8.0.0-py3-none-any.whl
  - sopel-help not installed

@Sigmanificient Sigmanificient marked this pull request as ready for review July 29, 2024 12:06
@Sigmanificient Sigmanificient force-pushed the pygeoip branch 2 times, most recently from 4aa2c13 to 6af46d0 Compare July 29, 2024 12:31
@emilazy
Copy link
Member

emilazy commented Aug 9, 2024

This seems reasonable but it’d probably be best to split out the substantive sopel changes into another PR, as they don’t seem necessary to drop this package and I’m not entirely sure how we should handle the circular dependency here.

@natsukium
Copy link
Member

Result of nixpkgs-review pr 330509 at 5f4744f0 run on x86_64-linux 1

2 packages failed to build:
3 packages built successfully:
  • nixpkgs-manual
  • python311Packages.sopel
  • python312Packages.sopel

@natsukium
Copy link
Member

I think the current hack is fine for the circular dependency, but sopel-help tests don't pass.

@emilazy
Copy link
Member

emilazy commented Aug 10, 2024

I was thinking we’d probably want a standard sopel installation to include sopel-help, since that seems to be the intention of the upstream, but I don’t know how that would be best accomplished (a wrapper package?). In any case it should be handled in another PR, I think.

@natsukium
Copy link
Member

We are working on separating build and runtime inputs for python packages in the future, and it will be resolved then. #272178

@Sigmanificient
Copy link
Member Author

Just removed sopel-help since is it no longer require, will open pr if I get it to build

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofborg build python3Packages.sopel

pkgs/development/python-modules/sopel/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@ofborg build python312Packages.sopel

@SuperSandro2000 SuperSandro2000 merged commit 3060364 into NixOS:master Aug 23, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants