Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcdf: fix darwin and more broadly clang builds #330670

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

mattpolzin
Copy link
Contributor

@mattpolzin mattpolzin commented Jul 28, 2024

Description of changes

As tracked upstream, later versions of clang produce warning that triggers failure when building netcdf. This PR introduces a tried and true strategy of ignoring those warnings for the time being -- many many projects are not as strict as the latest clang versions would have them be.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mattpolzin
Copy link
Contributor Author

Result of nixpkgs-review pr 330670 run on x86_64-darwin 1

35 packages marked as broken and skipped:
  • ezminc
  • gplates
  • nco
  • netcdfcxx4
  • ovito
  • python311Packages.arviz
  • python311Packages.arviz.dist
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.corner
  • python311Packages.corner.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.arviz
  • python312Packages.arviz.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.corner
  • python312Packages.corner.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
  • sumo
  • vpv
36 packages failed to build:
  • cdo
  • mni_autoreg
  • octavePackages.mapping
  • pymol
  • pymol.dist
  • python311Packages.gstools
  • python311Packages.gstools.dist
  • python311Packages.h5netcdf
  • python311Packages.h5netcdf.dist
  • python311Packages.meshio
  • python311Packages.meshio.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.qcodes
  • python311Packages.qcodes-contrib-drivers
  • python311Packages.qcodes-contrib-drivers.dist
  • python311Packages.qcodes.dist
  • python311Packages.sfepy
  • python311Packages.sfepy.dist
  • python312Packages.gstools
  • python312Packages.gstools.dist
  • python312Packages.h5netcdf
  • python312Packages.h5netcdf.dist
  • python312Packages.meshio
  • python312Packages.meshio.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.qcodes
  • python312Packages.qcodes-contrib-drivers
  • python312Packages.qcodes-contrib-drivers.dist
  • python312Packages.qcodes.dist
  • python312Packages.sfepy
  • python312Packages.sfepy.dist
  • python312Packages.wrf-python
  • python312Packages.wrf-python.dist
  • saga
131 packages built:
  • ants
  • bicgl
  • bicpl
  • c3d
  • conglomerate
  • ebtks
  • eccodes
  • elastix
  • gdal (python312Packages.gdal)
  • gmt
  • gnudatalanguage
  • grass
  • inormalize
  • itk
  • itk_5_2
  • libminc
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • minc_tools
  • minc_widgets
  • n3
  • ncview
  • netcdf
  • netcdf-mpi
  • netcdffortran
  • octavePackages.ncarray
  • octavePackages.netcdf
  • oobicpl
  • openorienteering-mapper
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • python311Packages.boltztrap2
  • python311Packages.boltztrap2.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.datashader
  • python311Packages.datashader.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.eccodes
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.gdal
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.netcdf4
  • python311Packages.netcdf4.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python311Packages.wrf-python
  • python311Packages.wrf-python.dist
  • python312Packages.boltztrap2
  • python312Packages.boltztrap2.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.eccodes
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.netcdf4
  • python312Packages.netcdf4.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.python-mapnik
  • python312Packages.python-mapnik.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • t-rex
  • udig

@mattpolzin mattpolzin mentioned this pull request Jul 31, 2024
13 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4376

@gador
Copy link
Member

gador commented Aug 6, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 330670 run on aarch64-darwin 1

48 packages marked as broken and skipped:
  • c3d
  • ezminc
  • gplates
  • labplot
  • nco
  • netcdfcxx4
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.flowmc
  • python311Packages.flowmc.dist
  • python311Packages.intensity-normalization
  • python311Packages.intensity-normalization.dist
  • python311Packages.medpy
  • python311Packages.medpy.dist
  • python311Packages.pydicom-seg
  • python311Packages.pydicom-seg.dist
  • python311Packages.pygmt
  • python311Packages.pygmt.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pymedio
  • python311Packages.pymedio.dist
  • python311Packages.pyradiomics
  • python311Packages.pyradiomics.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.torchio
  • python311Packages.torchio.dist
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.medpy
  • python312Packages.medpy.dist
  • python312Packages.pydicom-seg
  • python312Packages.pydicom-seg.dist
  • python312Packages.pygmt
  • python312Packages.pygmt.dist
  • python312Packages.pymedio
  • python312Packages.pymedio.dist
  • python312Packages.pyradiomics
  • python312Packages.pyradiomics.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.torchio
  • python312Packages.torchio.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
  • worldengine-cli
  • worldengine-cli.dist
2 packages failed to build and already failed to build on hydra master:
25 packages failed to build and are new build failures:
  • grass: plain log
  • merkaartor: log was empty
  • mni_autoreg: plain log
  • pymol.dist: plain log
  • python311Packages.arviz: log was empty
  • python311Packages.arviz.dist: log was empty
  • python311Packages.bsuite: log was empty
  • python311Packages.bsuite.dist: log was empty
  • python311Packages.corner: log was empty
  • python311Packages.corner.dist: log was empty
  • python311Packages.plotnine: plain log
  • python311Packages.plotnine.dist: plain log
  • python311Packages.qcodes: plain log
  • python311Packages.qcodes-contrib-drivers: log was empty
  • python311Packages.qcodes-contrib-drivers.dist: log was empty
  • python311Packages.qcodes.dist: plain log
  • python312Packages.arviz: log was empty
  • python312Packages.arviz.dist: log was empty
  • python312Packages.bsuite: log was empty
  • python312Packages.bsuite.dist: log was empty
  • python312Packages.corner: log was empty
  • python312Packages.corner.dist: log was empty
  • python312Packages.plotnine: plain log
  • python312Packages.plotnine.dist: plain log
  • python312Packages.wrf-python.dist: plain log
145 packages built:
  • ants
  • bicgl
  • bicpl
  • cdo
  • conglomerate
  • ebtks
  • eccodes
  • gdal (python312Packages.gdal)
  • gnudatalanguage
  • haskellPackages.hgdal
  • haskellPackages.hgdal.doc
  • inormalize
  • libminc
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • minc_tools
  • minc_widgets
  • n3
  • ncview
  • netcdf
  • netcdf-mpi
  • netcdffortran
  • oobicpl
  • openorienteering-mapper
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • python311Packages.boltztrap2
  • python311Packages.boltztrap2.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.datashader
  • python311Packages.datashader.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.eccodes
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.gdal
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.gstools
  • python311Packages.gstools.dist
  • python311Packages.h5netcdf
  • python311Packages.h5netcdf.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.meshio
  • python311Packages.meshio.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.netcdf4
  • python311Packages.netcdf4.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python311Packages.sfepy
  • python311Packages.sfepy.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python311Packages.wrf-python
  • python311Packages.wrf-python.dist
  • python312Packages.boltztrap2
  • python312Packages.boltztrap2.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.eccodes
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.gstools
  • python312Packages.gstools.dist
  • python312Packages.h5netcdf
  • python312Packages.h5netcdf.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.meshio
  • python312Packages.meshio.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.netcdf4
  • python312Packages.netcdf4.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.python-mapnik
  • python312Packages.python-mapnik.dist
  • python312Packages.qcodes
  • python312Packages.qcodes-contrib-drivers
  • python312Packages.qcodes-contrib-drivers.dist
  • python312Packages.qcodes.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • python312Packages.sfepy
  • python312Packages.sfepy.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • saga
  • t-rex

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

gdal:

got build log for '/nix/store/5dsz2dbx2a8w8hqdwphgzynkfjzq3qjm-gdal-3.9.1' from 'daemon'
When evaluating attribute ‘gdal’:
warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/development/libraries/gdal/default.nix:210:3:

    |
210 |   enableParallelBuilding = true;
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

haskellPackages.hgdal.doc:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

haskellPackages.hgdal:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/6rgl7llw3cag58sf5yr2x73iib4jz1gz-hgdal-1.0.0.1' from 'daemon'
When evaluating attribute ‘haskellPackages.hgdal’:
warning: build-tools-in-build-inputs
docbook_xml_dtd_43 is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
docbook-xsl-nons is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
getopt is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
gnum4 is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
gtk-doc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/haskell-modules/generic-builder.nix:847:3:

    |
847 |   meta = { inherit homepage license platforms; }
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

netcdffortran:

got build log for '/nix/store/1raamzh5l2l52jmviji97g0is3fklpki-netcdf-fortran-4.4.5' from 'daemon'
When evaluating attribute ‘netcdffortran’:
warning: attribute-typo
A likely typo in the FFLAGS argument was found, did you mean CFLAGS or FCFLAGS?

Near pkgs/development/libraries/netcdf-fortran/default.nix:26:3:

   |
26 |   FFLAGS = [ "-std=legacy" ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: environment-variables-go-to-env
Environment variable FCFLAGS should be moved to env attribute rather than being passed directly to ‘stdenv.mkDerivation’.

Near pkgs/development/libraries/netcdf-fortran/default.nix:27:3:

   |
27 |   FCFLAGS = [ "-std=legacy" ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/environment-variables-go-to-env.md

netcdf:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/lq2622aigvm00q35w74j1psr711id5k7-netcdf-4.9.2' from 'daemon'
When evaluating attribute ‘netcdf’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/netcdf/default.nix:84:3:

   |
84 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

netcdf-mpi:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/56kad08qm6cjp4sg7vwibap7scgi8455-netcdf-mpi-4.9.2' from 'daemon'
When evaluating attribute ‘netcdf-mpi’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/netcdf/default.nix:84:3:

   |
84 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.boltztrap2.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/r6bjdjj60pnq7anymj6x94v1hl5n1r6r-python3.11-boltztrap2-24.1.1-dist' from 'daemon'
When evaluating attribute ‘python311Packages.boltztrap2.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:

   |
63 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.boltztrap2:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/23pprr1pqi5izwhqxrz0f80jhys7dhk4-python3.11-boltztrap2-24.1.1' from 'daemon'
When evaluating attribute ‘python311Packages.boltztrap2’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:

   |
63 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.datashader.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/datashader/default.nix:99:5:

   |
99 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.datashader:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/datashader/default.nix:99:5:

   |
99 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.h5netcdf.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/5kmlncaib4342ph0xzsr36ll9lrh2qm9-python3.11-h5netcdf-1.3.0-dist' from 'daemon'
When evaluating attribute ‘python311Packages.h5netcdf.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:

   |
46 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.h5netcdf:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/nvrm6p38d9pz8qb77vxxrb749r076gnf-python3.11-h5netcdf-1.3.0' from 'daemon'
When evaluating attribute ‘python311Packages.h5netcdf’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:

   |
46 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.netcdf4.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/g0dh3aw2698y96dffr76hi7pfjzgg6vi-python3.11-netcdf4-1.6.5-dist' from 'daemon'
When evaluating attribute ‘python311Packages.netcdf4.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/netcdf4/default.nix:73:5:

   |
73 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.netcdf4:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/xdjm1v8fv90i97549b8vvmdphd6b1r4m-python3.11-netcdf4-1.6.5' from 'daemon'
When evaluating attribute ‘python311Packages.netcdf4’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/netcdf4/default.nix:73:5:

   |
73 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.python-mapnik.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/8wrxaah1vbrxh9n6bd8yardc711gcr4m-python3.11-python-mapnik-3.0.16-unstable-2024-02-22-dist' from 'daemon'
When evaluating attribute ‘python311Packages.python-mapnik.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:

    |
132 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.python-mapnik:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/77lvh5vsny6jbli6m8x3xg4vqsap7q0j-python3.11-python-mapnik-3.0.16-unstable-2024-02-22' from 'daemon'
When evaluating attribute ‘python311Packages.python-mapnik’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:

    |
132 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.boltztrap2.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/98sg38dk427vzlk2jj33bmil2h558v64-python3.12-boltztrap2-24.1.1-dist' from 'daemon'
When evaluating attribute ‘python312Packages.boltztrap2.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:

   |
63 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.boltztrap2:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/n9jjmb99301slaakvhqbk3jfcff04n2w-python3.12-boltztrap2-24.1.1' from 'daemon'
When evaluating attribute ‘python312Packages.boltztrap2’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:

   |
63 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.h5netcdf.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/ji9vkrc8wjlfsl8vwh7w6xcf40k3a4mq-python3.12-h5netcdf-1.3.0-dist' from 'daemon'
When evaluating attribute ‘python312Packages.h5netcdf.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:

   |
46 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.h5netcdf:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/irg2a9x8i9rqm8mq48jbg6q8y0i8ciqv-python3.12-h5netcdf-1.3.0' from 'daemon'
When evaluating attribute ‘python312Packages.h5netcdf’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:

   |
46 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.netcdf4.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/d2mv1hqmy8r9c2ysnl9vrkw1q7ahpfb4-python3.12-netcdf4-1.6.5-dist' from 'daemon'
When evaluating attribute ‘python312Packages.netcdf4.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/netcdf4/default.nix:73:5:

   |
73 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.netcdf4:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/0mv2ba9kvqnzmhycvmlxn9i4hdsn4w1s-python3.12-netcdf4-1.6.5' from 'daemon'
When evaluating attribute ‘python312Packages.netcdf4’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/netcdf4/default.nix:73:5:

   |
73 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.python-mapnik.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:

    |
132 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.python-mapnik:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:

    |
132 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

t-rex:

warning: environment-variables-go-to-env
Environment variable PKG_CONFIG_ALLOW_CROSS should be moved to env attribute rather than being passed directly to ‘stdenv.mkDerivation’.

Near pkgs/build-support/rust/build-rust-package/default.nix:135:3:

    |
135 |   PKG_CONFIG_ALLOW_CROSS =
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/environment-variables-go-to-env.md

@gador
Copy link
Member

gador commented Aug 7, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 330670 run on x86_64-linux 1

13 packages marked as broken and skipped:
  • ezminc
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.sunpy
  • python311Packages.sunpy.dist
  • python311Packages.worldengine
  • python311Packages.worldengine.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.worldengine
  • python312Packages.worldengine.dist
  • worldengine-cli
  • worldengine-cli.dist
8 packages failed to build and already failed to build on hydra master:
  • gmt: plain log
  • labplot: log was empty
  • pymol: plain log
  • python311Packages.pydicom-seg: plain log
  • python311Packages.pygmt: log was empty
  • python312Packages.pydicom-seg: plain log
  • python312Packages.pygmt: log was empty
  • python312Packages.wrf-python: plain log
6 packages failed to build and are new build failures:
  • pymol.dist: plain log
  • python311Packages.pydicom-seg.dist: plain log
  • python311Packages.pygmt.dist: log was empty
  • python312Packages.pydicom-seg.dist: plain log
  • python312Packages.pygmt.dist: log was empty
  • python312Packages.wrf-python.dist: plain log
225 packages built:
  • ants
  • apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
  • bicgl
  • bicpl
  • c3d
  • cdo
  • cloudcompare
  • conglomerate
  • ebtks
  • eccodes
  • elastix
  • entwine
  • gdal (python312Packages.gdal)
  • gnudatalanguage
  • gplates
  • grass
  • haskellPackages.hgdal
  • haskellPackages.hgdal.doc
  • inormalize
  • itk (itk_5)
  • itk_5_2
  • libminc
  • mapcache
  • mapnik
  • mapproxy
  • mapproxy.dist
  • mapserver
  • merkaartor
  • minc_tools
  • minc_widgets
  • mirtk
  • mni_autoreg
  • mrtrix
  • mysql-workbench
  • n3
  • nco
  • ncview
  • netcdf
  • netcdf-mpi
  • netcdfcxx4
  • netcdffortran
  • nixpkgs-manual
  • octavePackages.mapping
  • octavePackages.ncarray
  • octavePackages.netcdf
  • octopus
  • oobicpl
  • openorienteering-mapper
  • ovito
  • paraview
  • pdal
  • perl536Packages.Tirex
  • perl536Packages.Tirex.devdoc
  • perl538Packages.Tirex
  • perl538Packages.Tirex.devdoc
  • python311Packages.arviz
  • python311Packages.arviz.dist
  • python311Packages.boltztrap2
  • python311Packages.boltztrap2.dist
  • python311Packages.bsuite
  • python311Packages.bsuite.dist
  • python311Packages.cartopy
  • python311Packages.cartopy.dist
  • python311Packages.corner
  • python311Packages.corner.dist
  • python311Packages.datashader
  • python311Packages.datashader.dist
  • python311Packages.django-bootstrap4
  • python311Packages.django-bootstrap4.dist
  • python311Packages.django-bootstrap5
  • python311Packages.django-bootstrap5.dist
  • python311Packages.eccodes
  • python311Packages.fiona
  • python311Packages.fiona.dist
  • python311Packages.flowmc
  • python311Packages.flowmc.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.gdal
  • python311Packages.geodatasets
  • python311Packages.geodatasets.dist
  • python311Packages.geopandas
  • python311Packages.geopandas.dist
  • python311Packages.gstools
  • python311Packages.gstools.dist
  • python311Packages.h5netcdf
  • python311Packages.h5netcdf.dist
  • python311Packages.inequality
  • python311Packages.inequality.dist
  • python311Packages.intensity-normalization
  • python311Packages.intensity-normalization.dist
  • python311Packages.libpysal
  • python311Packages.libpysal.dist
  • python311Packages.mapclassify
  • python311Packages.mapclassify.dist
  • python311Packages.medpy
  • python311Packages.medpy.dist
  • python311Packages.meshio
  • python311Packages.meshio.dist
  • python311Packages.momepy
  • python311Packages.momepy.dist
  • python311Packages.morecantile
  • python311Packages.morecantile.dist
  • python311Packages.netcdf4
  • python311Packages.netcdf4.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.plotnine
  • python311Packages.plotnine.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pymedio
  • python311Packages.pymedio.dist
  • python311Packages.pyogrio
  • python311Packages.pyogrio.dist
  • python311Packages.pyradiomics
  • python311Packages.pyradiomics.dist
  • python311Packages.python-mapnik
  • python311Packages.python-mapnik.dist
  • python311Packages.qcodes
  • python311Packages.qcodes-contrib-drivers
  • python311Packages.qcodes-contrib-drivers.dist
  • python311Packages.qcodes.dist
  • python311Packages.rasterio
  • python311Packages.rasterio.dist
  • python311Packages.rio-tiler
  • python311Packages.rio-tiler.dist
  • python311Packages.rioxarray
  • python311Packages.rioxarray.dist
  • python311Packages.sfepy
  • python311Packages.sfepy.dist
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
  • python311Packages.simpleitk
  • python311Packages.simpleitk.dist
  • python311Packages.torchio
  • python311Packages.torchio.dist
  • python311Packages.wktutils
  • python311Packages.wktutils.dist
  • python311Packages.wrf-python
  • python311Packages.wrf-python.dist
  • python312Packages.arviz
  • python312Packages.arviz.dist
  • python312Packages.boltztrap2
  • python312Packages.boltztrap2.dist
  • python312Packages.bsuite
  • python312Packages.bsuite.dist
  • python312Packages.cartopy
  • python312Packages.cartopy.dist
  • python312Packages.corner
  • python312Packages.corner.dist
  • python312Packages.django-bootstrap4
  • python312Packages.django-bootstrap4.dist
  • python312Packages.django-bootstrap5
  • python312Packages.django-bootstrap5.dist
  • python312Packages.eccodes
  • python312Packages.fiona
  • python312Packages.fiona.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.geodatasets
  • python312Packages.geodatasets.dist
  • python312Packages.geopandas
  • python312Packages.geopandas.dist
  • python312Packages.gstools
  • python312Packages.gstools.dist
  • python312Packages.h5netcdf
  • python312Packages.h5netcdf.dist
  • python312Packages.inequality
  • python312Packages.inequality.dist
  • python312Packages.libpysal
  • python312Packages.libpysal.dist
  • python312Packages.mapclassify
  • python312Packages.mapclassify.dist
  • python312Packages.medpy
  • python312Packages.medpy.dist
  • python312Packages.meshio
  • python312Packages.meshio.dist
  • python312Packages.momepy
  • python312Packages.momepy.dist
  • python312Packages.morecantile
  • python312Packages.morecantile.dist
  • python312Packages.netcdf4
  • python312Packages.netcdf4.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.plotnine
  • python312Packages.plotnine.dist
  • python312Packages.pymedio
  • python312Packages.pymedio.dist
  • python312Packages.pyogrio
  • python312Packages.pyogrio.dist
  • python312Packages.pyradiomics
  • python312Packages.pyradiomics.dist
  • python312Packages.python-mapnik
  • python312Packages.python-mapnik.dist
  • python312Packages.qcodes
  • python312Packages.qcodes-contrib-drivers
  • python312Packages.qcodes-contrib-drivers.dist
  • python312Packages.qcodes.dist
  • python312Packages.rasterio
  • python312Packages.rasterio.dist
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
  • python312Packages.rioxarray
  • python312Packages.rioxarray.dist
  • python312Packages.sfepy
  • python312Packages.sfepy.dist
  • python312Packages.simpleitk
  • python312Packages.simpleitk.dist
  • python312Packages.torchio
  • python312Packages.torchio.dist
  • python312Packages.wktutils
  • python312Packages.wktutils.dist
  • pytrainer
  • pytrainer.dist
  • qgis
  • qgis-ltr
  • qmapshack
  • saga
  • simpleitk
  • sumo
  • t-rex
  • udig
  • vpv

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

apacheHttpdPackages.mod_tile:

got build log for '/nix/store/4lcwvxl8jd962lf6pwn6aik7gnhmii1d-mod_tile-0.7.1' from 'daemon'
When evaluating attribute ‘apacheHttpdPackages.mod_tile’:
warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/servers/http/apache-modules/mod_tile/default.nix:57:3:

   |
57 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

c3d:

got build log for '/nix/store/30rl757iicanhdwy1g897s8hsaiawn8i-c3d-unstable-2021-09-14' from 'daemon'
When evaluating attribute ‘c3d’:
warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/applications/graphics/c3d/default.nix:25:5:

   |
25 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

gdal:

got build log for '/nix/store/5dsz2dbx2a8w8hqdwphgzynkfjzq3qjm-gdal-3.9.1' from 'daemon'
When evaluating attribute ‘gdal’:
warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/development/libraries/gdal/default.nix:210:3:

    |
210 |   enableParallelBuilding = true;
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

gplates:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/lmgafhj0hy9a8rlhdbiz23vd9jwd890d-gplates-2.5' from 'daemon'
When evaluating attribute ‘gplates’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/applications/science/misc/gplates/default.nix:68:3:

   |
68 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

haskellPackages.hgdal.doc:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

haskellPackages.hgdal:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/6rgl7llw3cag58sf5yr2x73iib4jz1gz-hgdal-1.0.0.1' from 'daemon'
When evaluating attribute ‘haskellPackages.hgdal’:
warning: build-tools-in-build-inputs
docbook_xml_dtd_43 is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
docbook-xsl-nons is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
getopt is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
gnum4 is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
gtk-doc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/haskell-modules/generic-builder.nix:460:3:

    |
460 |   buildInputs = otherBuildInputs ++ optionals (!isLibrary) propagatedBuildInputs
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/haskell-modules/generic-builder.nix:847:3:

    |
847 |   meta = { inherit homepage license platforms; }
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

itk_5_2:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/9jphy61mqr5pp3f7r0h5j4w9nwwr4rxz-itk-5.2.1' from 'daemon'
When evaluating attribute ‘itk_5_2’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/itk/generic.nix:115:5:

    |
115 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

itk:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/z13qm50c8dxkylhxj0l90v77w528iq3c-itk-5.4.0' from 'daemon'
When evaluating attribute ‘itk’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/itk/generic.nix:115:5:

    |
115 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

netcdfcxx4:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/2ahp31xz59mp7pbk7n6qv038zja8y88v-netcdf-cxx4-4.3.1' from 'daemon'
When evaluating attribute ‘netcdfcxx4’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/netcdf-cxx4/default.nix:31:3:

   |
31 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

netcdffortran:

got build log for '/nix/store/1raamzh5l2l52jmviji97g0is3fklpki-netcdf-fortran-4.4.5' from 'daemon'
When evaluating attribute ‘netcdffortran’:
warning: attribute-typo
A likely typo in the FFLAGS argument was found, did you mean CFLAGS or FCFLAGS?

Near pkgs/development/libraries/netcdf-fortran/default.nix:26:3:

   |
26 |   FFLAGS = [ "-std=legacy" ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: environment-variables-go-to-env
Environment variable FCFLAGS should be moved to env attribute rather than being passed directly to ‘stdenv.mkDerivation’.

Near pkgs/development/libraries/netcdf-fortran/default.nix:27:3:

   |
27 |   FCFLAGS = [ "-std=legacy" ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/environment-variables-go-to-env.md

netcdf:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/lq2622aigvm00q35w74j1psr711id5k7-netcdf-4.9.2' from 'daemon'
When evaluating attribute ‘netcdf’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/netcdf/default.nix:84:3:

   |
84 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

netcdf-mpi:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/56kad08qm6cjp4sg7vwibap7scgi8455-netcdf-mpi-4.9.2' from 'daemon'
When evaluating attribute ‘netcdf-mpi’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/netcdf/default.nix:84:3:

   |
84 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

nixpkgs-manual:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

octavePackages.mapping:

got build log for '/nix/store/hw2a50vm1x38rss2z8pfiqv562zgp28y-octave-9.2.0-mapping-1.4.2' from 'daemon'
When evaluating attribute ‘octavePackages.mapping’:
warning: patch-phase
patchPhase should not be overridden, use postPatch instead.

Near pkgs/development/interpreters/octave/build-octave-package.nix:96:10:

   |
96 |   inherit dontPatch patches patchPhase;
   |          ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md

octavePackages.ncarray:

got build log for '/nix/store/n46jbznf1izv6bpgcbgg9w9nlm0049m6-octave-9.2.0-ncarray-1.0.6' from 'daemon'
When evaluating attribute ‘octavePackages.ncarray’:
warning: patch-phase
patchPhase should not be overridden, use postPatch instead.

Near pkgs/development/interpreters/octave/build-octave-package.nix:96:10:

   |
96 |   inherit dontPatch patches patchPhase;
   |          ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md

octavePackages.netcdf:

got build log for '/nix/store/rcq1vcip3142904csi1abz7dk04y0ndz-octave-9.2.0-netcdf-1.0.17' from 'daemon'
When evaluating attribute ‘octavePackages.netcdf’:
warning: patch-phase
patchPhase should not be overridden, use postPatch instead.

Near pkgs/development/interpreters/octave/build-octave-package.nix:96:10:

   |
96 |   inherit dontPatch patches patchPhase;
   |          ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md

octopus:

got build log for '/nix/store/00afix2mwkb1sq2c0s5qiafxrwbfjkb9-octopus-14.1' from 'daemon'
When evaluating attribute ‘octopus’:
warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/applications/science/chemistry/octopus/default.nix:88:3:

   |
88 |   enableParallelBuilding = true;
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

python311Packages.boltztrap2.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/r6bjdjj60pnq7anymj6x94v1hl5n1r6r-python3.11-boltztrap2-24.1.1-dist' from 'daemon'
When evaluating attribute ‘python311Packages.boltztrap2.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:

   |
63 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.boltztrap2:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/23pprr1pqi5izwhqxrz0f80jhys7dhk4-python3.11-boltztrap2-24.1.1' from 'daemon'
When evaluating attribute ‘python311Packages.boltztrap2’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:

   |
63 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.datashader.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/sjaxlrdirvlb71g9c31icw3py1ykm8l4-python3.11-datashader-0.16.2-dist' from 'daemon'
When evaluating attribute ‘python311Packages.datashader.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/datashader/default.nix:99:5:

   |
99 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.datashader:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/9ngvkx4968knpm43g7z91cy6zb0rzywb-python3.11-datashader-0.16.2' from 'daemon'
When evaluating attribute ‘python311Packages.datashader’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/datashader/default.nix:99:5:

   |
99 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.h5netcdf.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/5kmlncaib4342ph0xzsr36ll9lrh2qm9-python3.11-h5netcdf-1.3.0-dist' from 'daemon'
When evaluating attribute ‘python311Packages.h5netcdf.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:

   |
46 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.h5netcdf:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/nvrm6p38d9pz8qb77vxxrb749r076gnf-python3.11-h5netcdf-1.3.0' from 'daemon'
When evaluating attribute ‘python311Packages.h5netcdf’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:

   |
46 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.netcdf4.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/g0dh3aw2698y96dffr76hi7pfjzgg6vi-python3.11-netcdf4-1.6.5-dist' from 'daemon'
When evaluating attribute ‘python311Packages.netcdf4.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/netcdf4/default.nix:73:5:

   |
73 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.netcdf4:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/xdjm1v8fv90i97549b8vvmdphd6b1r4m-python3.11-netcdf4-1.6.5' from 'daemon'
When evaluating attribute ‘python311Packages.netcdf4’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/netcdf4/default.nix:73:5:

   |
73 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.python-mapnik.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/8wrxaah1vbrxh9n6bd8yardc711gcr4m-python3.11-python-mapnik-3.0.16-unstable-2024-02-22-dist' from 'daemon'
When evaluating attribute ‘python311Packages.python-mapnik.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:

    |
132 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.python-mapnik:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/77lvh5vsny6jbli6m8x3xg4vqsap7q0j-python3.11-python-mapnik-3.0.16-unstable-2024-02-22' from 'daemon'
When evaluating attribute ‘python311Packages.python-mapnik’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:

    |
132 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.boltztrap2.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/98sg38dk427vzlk2jj33bmil2h558v64-python3.12-boltztrap2-24.1.1-dist' from 'daemon'
When evaluating attribute ‘python312Packages.boltztrap2.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:

   |
63 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.boltztrap2:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/n9jjmb99301slaakvhqbk3jfcff04n2w-python3.12-boltztrap2-24.1.1' from 'daemon'
When evaluating attribute ‘python312Packages.boltztrap2’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:

   |
63 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.h5netcdf.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/ji9vkrc8wjlfsl8vwh7w6xcf40k3a4mq-python3.12-h5netcdf-1.3.0-dist' from 'daemon'
When evaluating attribute ‘python312Packages.h5netcdf.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:

   |
46 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.h5netcdf:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/irg2a9x8i9rqm8mq48jbg6q8y0i8ciqv-python3.12-h5netcdf-1.3.0' from 'daemon'
When evaluating attribute ‘python312Packages.h5netcdf’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:

   |
46 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.netcdf4.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/d2mv1hqmy8r9c2ysnl9vrkw1q7ahpfb4-python3.12-netcdf4-1.6.5-dist' from 'daemon'
When evaluating attribute ‘python312Packages.netcdf4.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/netcdf4/default.nix:73:5:

   |
73 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.netcdf4:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/0mv2ba9kvqnzmhycvmlxn9i4hdsn4w1s-python3.12-netcdf4-1.6.5' from 'daemon'
When evaluating attribute ‘python312Packages.netcdf4’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/netcdf4/default.nix:73:5:

   |
73 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.python-mapnik.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/1czak465cz4hsr4q8avlipvi1nffzz0p-python3.12-python-mapnik-3.0.16-unstable-2024-02-22-dist' from 'daemon'
When evaluating attribute ‘python312Packages.python-mapnik.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:

    |
132 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.python-mapnik:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/nyi30sjszm9l2d7m2w0zwfdjwl4wim4y-python3.12-python-mapnik-3.0.16-unstable-2024-02-22' from 'daemon'
When evaluating attribute ‘python312Packages.python-mapnik’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:

    |
132 |     maintainers = [ ];
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

t-rex:

got build log for '/nix/store/lmlpsvbzdgcj7sm5l70wn60brkbcvjs3-t-rex-0.15.0-alpha3' from 'daemon'
When evaluating attribute ‘t-rex’:
warning: environment-variables-go-to-env
Environment variable PKG_CONFIG_ALLOW_CROSS should be moved to env attribute rather than being passed directly to ‘stdenv.mkDerivation’.

Near pkgs/build-support/rust/build-rust-package/default.nix:135:3:

    |
135 |   PKG_CONFIG_ALLOW_CROSS =
    |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/environment-variables-go-to-env.md

vpv:

got build log for '/nix/store/l9w71cg465jamybpdmnx8lb9niqvr0zq-vpv-0.8.2' from 'daemon'
When evaluating attribute ‘vpv’:
warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/applications/graphics/vpv/default.nix:60:5:

   |
60 |     license = lib.licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@mattpolzin
Copy link
Contributor Author

Thanks for running those reviews; my Linux laptop crashed before it finished with the review script 😅.

I'm a bit surprised to see new failures introduced according to the Linux review pass; I wonder if that's possibly not the correct interpretation of those failures (they are new as of some previous Hydra run but not specifically introduced by this PR).

@mattpolzin
Copy link
Contributor Author

mattpolzin commented Aug 7, 2024

Ok, I didn't check all of the 6 "new failures" but I did check the first two (pymol.dist and python311Packages.pydicom-seg.dist) which fail on master as well and that lends credence to the theory that these are not truly new failures as-in "caused by this PR."

@gador
Copy link
Member

gador commented Aug 8, 2024

I can confirm that all packages, which fail here for x86_64-linux, fail on current master, too.

@gador
Copy link
Member

gador commented Aug 8, 2024

I can also confirm that all packages marked as "new build failures" on aarch64-darwin are already present on master (mostly due to error: Package ‘pmix-5.0.3’ in [...]/pkgs/development/libraries/pmix/default.nix:82 is not available on the requested hostPlatform)

@gador
Copy link
Member

gador commented Aug 8, 2024

Although this will cause a few rebuilds, it still isn't enough to warrant a staging cycle, so I am fine merging this to master

@gador gador merged commit 81f33f4 into NixOS:master Aug 8, 2024
46 checks passed
@mattpolzin mattpolzin deleted the netcdf-fix-darwin branch August 8, 2024 11:30
@WardF
Copy link

WardF commented Aug 13, 2024

I've put up a PR to hopefully address this in the netCDF v4.9.3, Unidata/netcdf-c#2977.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants