-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netcdf: fix darwin and more broadly clang builds #330670
Conversation
Result of 35 packages marked as broken and skipped:
36 packages failed to build:
131 packages built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4376 |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 48 packages marked as broken and skipped:
2 packages failed to build and already failed to build on hydra master:25 packages failed to build and are new build failures:
145 packages built:
The following issues got detected with the above build packages.
gdal:
got build log for '/nix/store/5dsz2dbx2a8w8hqdwphgzynkfjzq3qjm-gdal-3.9.1' from 'daemon' Near pkgs/development/libraries/gdal/default.nix:210:3:
Package is missing maintainers. Package is missing maintainers. got build log for '/nix/store/6rgl7llw3cag58sf5yr2x73iib4jz1gz-hgdal-1.0.0.1' from 'daemon' Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:847:3:
got build log for '/nix/store/1raamzh5l2l52jmviji97g0is3fklpki-netcdf-fortran-4.4.5' from 'daemon' Near pkgs/development/libraries/netcdf-fortran/default.nix:26:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md Near pkgs/development/libraries/netcdf-fortran/default.nix:27:3:
Package is missing maintainers. got build log for '/nix/store/lq2622aigvm00q35w74j1psr711id5k7-netcdf-4.9.2' from 'daemon' Near pkgs/development/libraries/netcdf/default.nix:84:3:
Package is missing maintainers. got build log for '/nix/store/56kad08qm6cjp4sg7vwibap7scgi8455-netcdf-mpi-4.9.2' from 'daemon' Near pkgs/development/libraries/netcdf/default.nix:84:3:
Package is missing maintainers. got build log for '/nix/store/r6bjdjj60pnq7anymj6x94v1hl5n1r6r-python3.11-boltztrap2-24.1.1-dist' from 'daemon' Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:
Package is missing maintainers. got build log for '/nix/store/23pprr1pqi5izwhqxrz0f80jhys7dhk4-python3.11-boltztrap2-24.1.1' from 'daemon' Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:
Package is missing maintainers. warning: maintainers-missing Near pkgs/development/python-modules/datashader/default.nix:99:5:
Package is missing maintainers. warning: maintainers-missing Near pkgs/development/python-modules/datashader/default.nix:99:5:
Package is missing maintainers. got build log for '/nix/store/5kmlncaib4342ph0xzsr36ll9lrh2qm9-python3.11-h5netcdf-1.3.0-dist' from 'daemon' Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:
Package is missing maintainers. got build log for '/nix/store/nvrm6p38d9pz8qb77vxxrb749r076gnf-python3.11-h5netcdf-1.3.0' from 'daemon' Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:
Package is missing maintainers. got build log for '/nix/store/g0dh3aw2698y96dffr76hi7pfjzgg6vi-python3.11-netcdf4-1.6.5-dist' from 'daemon' Near pkgs/development/python-modules/netcdf4/default.nix:73:5:
Package is missing maintainers. got build log for '/nix/store/xdjm1v8fv90i97549b8vvmdphd6b1r4m-python3.11-netcdf4-1.6.5' from 'daemon' Near pkgs/development/python-modules/netcdf4/default.nix:73:5:
Package is missing maintainers. got build log for '/nix/store/8wrxaah1vbrxh9n6bd8yardc711gcr4m-python3.11-python-mapnik-3.0.16-unstable-2024-02-22-dist' from 'daemon' Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:
Package is missing maintainers. got build log for '/nix/store/77lvh5vsny6jbli6m8x3xg4vqsap7q0j-python3.11-python-mapnik-3.0.16-unstable-2024-02-22' from 'daemon' Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:
Package is missing maintainers. got build log for '/nix/store/98sg38dk427vzlk2jj33bmil2h558v64-python3.12-boltztrap2-24.1.1-dist' from 'daemon' Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:
Package is missing maintainers. got build log for '/nix/store/n9jjmb99301slaakvhqbk3jfcff04n2w-python3.12-boltztrap2-24.1.1' from 'daemon' Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:
Package is missing maintainers. got build log for '/nix/store/ji9vkrc8wjlfsl8vwh7w6xcf40k3a4mq-python3.12-h5netcdf-1.3.0-dist' from 'daemon' Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:
Package is missing maintainers. got build log for '/nix/store/irg2a9x8i9rqm8mq48jbg6q8y0i8ciqv-python3.12-h5netcdf-1.3.0' from 'daemon' Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:
Package is missing maintainers. got build log for '/nix/store/d2mv1hqmy8r9c2ysnl9vrkw1q7ahpfb4-python3.12-netcdf4-1.6.5-dist' from 'daemon' Near pkgs/development/python-modules/netcdf4/default.nix:73:5:
Package is missing maintainers. got build log for '/nix/store/0mv2ba9kvqnzmhycvmlxn9i4hdsn4w1s-python3.12-netcdf4-1.6.5' from 'daemon' Near pkgs/development/python-modules/netcdf4/default.nix:73:5:
Package is missing maintainers. warning: maintainers-missing Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:
Package is missing maintainers. warning: maintainers-missing Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:
warning: environment-variables-go-to-env Near pkgs/build-support/rust/build-rust-package/default.nix:135:3:
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 13 packages marked as broken and skipped:
8 packages failed to build and already failed to build on hydra master:6 packages failed to build and are new build failures:225 packages built:
The following issues got detected with the above build packages.
apacheHttpdPackages.mod_tile:
got build log for '/nix/store/4lcwvxl8jd962lf6pwn6aik7gnhmii1d-mod_tile-0.7.1' from 'daemon' Near pkgs/servers/http/apache-modules/mod_tile/default.nix:57:3:
got build log for '/nix/store/30rl757iicanhdwy1g897s8hsaiawn8i-c3d-unstable-2021-09-14' from 'daemon' Near pkgs/applications/graphics/c3d/default.nix:25:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md got build log for '/nix/store/5dsz2dbx2a8w8hqdwphgzynkfjzq3qjm-gdal-3.9.1' from 'daemon' Near pkgs/development/libraries/gdal/default.nix:210:3:
Package is missing maintainers. got build log for '/nix/store/lmgafhj0hy9a8rlhdbiz23vd9jwd890d-gplates-2.5' from 'daemon' Near pkgs/applications/science/misc/gplates/default.nix:68:3:
Package is missing maintainers. Package is missing maintainers. got build log for '/nix/store/6rgl7llw3cag58sf5yr2x73iib4jz1gz-hgdal-1.0.0.1' from 'daemon' Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:460:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:847:3:
Package is missing maintainers. got build log for '/nix/store/9jphy61mqr5pp3f7r0h5j4w9nwwr4rxz-itk-5.2.1' from 'daemon' Near pkgs/development/libraries/itk/generic.nix:115:5:
Package is missing maintainers. got build log for '/nix/store/z13qm50c8dxkylhxj0l90v77w528iq3c-itk-5.4.0' from 'daemon' Near pkgs/development/libraries/itk/generic.nix:115:5:
Package is missing maintainers. got build log for '/nix/store/2ahp31xz59mp7pbk7n6qv038zja8y88v-netcdf-cxx4-4.3.1' from 'daemon' Near pkgs/development/libraries/netcdf-cxx4/default.nix:31:3:
got build log for '/nix/store/1raamzh5l2l52jmviji97g0is3fklpki-netcdf-fortran-4.4.5' from 'daemon' Near pkgs/development/libraries/netcdf-fortran/default.nix:26:3:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md Near pkgs/development/libraries/netcdf-fortran/default.nix:27:3:
Package is missing maintainers. got build log for '/nix/store/lq2622aigvm00q35w74j1psr711id5k7-netcdf-4.9.2' from 'daemon' Near pkgs/development/libraries/netcdf/default.nix:84:3:
Package is missing maintainers. got build log for '/nix/store/56kad08qm6cjp4sg7vwibap7scgi8455-netcdf-mpi-4.9.2' from 'daemon' Near pkgs/development/libraries/netcdf/default.nix:84:3:
Package is missing maintainers. got build log for '/nix/store/hw2a50vm1x38rss2z8pfiqv562zgp28y-octave-9.2.0-mapping-1.4.2' from 'daemon' Near pkgs/development/interpreters/octave/build-octave-package.nix:96:10:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md got build log for '/nix/store/n46jbznf1izv6bpgcbgg9w9nlm0049m6-octave-9.2.0-ncarray-1.0.6' from 'daemon' Near pkgs/development/interpreters/octave/build-octave-package.nix:96:10:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md got build log for '/nix/store/rcq1vcip3142904csi1abz7dk04y0ndz-octave-9.2.0-netcdf-1.0.17' from 'daemon' Near pkgs/development/interpreters/octave/build-octave-package.nix:96:10:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md got build log for '/nix/store/00afix2mwkb1sq2c0s5qiafxrwbfjkb9-octopus-14.1' from 'daemon' Near pkgs/applications/science/chemistry/octopus/default.nix:88:3:
Package is missing maintainers. got build log for '/nix/store/r6bjdjj60pnq7anymj6x94v1hl5n1r6r-python3.11-boltztrap2-24.1.1-dist' from 'daemon' Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:
Package is missing maintainers. got build log for '/nix/store/23pprr1pqi5izwhqxrz0f80jhys7dhk4-python3.11-boltztrap2-24.1.1' from 'daemon' Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:
Package is missing maintainers. got build log for '/nix/store/sjaxlrdirvlb71g9c31icw3py1ykm8l4-python3.11-datashader-0.16.2-dist' from 'daemon' Near pkgs/development/python-modules/datashader/default.nix:99:5:
Package is missing maintainers. got build log for '/nix/store/9ngvkx4968knpm43g7z91cy6zb0rzywb-python3.11-datashader-0.16.2' from 'daemon' Near pkgs/development/python-modules/datashader/default.nix:99:5:
Package is missing maintainers. got build log for '/nix/store/5kmlncaib4342ph0xzsr36ll9lrh2qm9-python3.11-h5netcdf-1.3.0-dist' from 'daemon' Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:
Package is missing maintainers. got build log for '/nix/store/nvrm6p38d9pz8qb77vxxrb749r076gnf-python3.11-h5netcdf-1.3.0' from 'daemon' Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:
Package is missing maintainers. got build log for '/nix/store/g0dh3aw2698y96dffr76hi7pfjzgg6vi-python3.11-netcdf4-1.6.5-dist' from 'daemon' Near pkgs/development/python-modules/netcdf4/default.nix:73:5:
Package is missing maintainers. got build log for '/nix/store/xdjm1v8fv90i97549b8vvmdphd6b1r4m-python3.11-netcdf4-1.6.5' from 'daemon' Near pkgs/development/python-modules/netcdf4/default.nix:73:5:
Package is missing maintainers. got build log for '/nix/store/8wrxaah1vbrxh9n6bd8yardc711gcr4m-python3.11-python-mapnik-3.0.16-unstable-2024-02-22-dist' from 'daemon' Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:
Package is missing maintainers. got build log for '/nix/store/77lvh5vsny6jbli6m8x3xg4vqsap7q0j-python3.11-python-mapnik-3.0.16-unstable-2024-02-22' from 'daemon' Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:
Package is missing maintainers. got build log for '/nix/store/98sg38dk427vzlk2jj33bmil2h558v64-python3.12-boltztrap2-24.1.1-dist' from 'daemon' Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:
Package is missing maintainers. got build log for '/nix/store/n9jjmb99301slaakvhqbk3jfcff04n2w-python3.12-boltztrap2-24.1.1' from 'daemon' Near pkgs/development/python-modules/boltztrap2/default.nix:63:5:
Package is missing maintainers. got build log for '/nix/store/ji9vkrc8wjlfsl8vwh7w6xcf40k3a4mq-python3.12-h5netcdf-1.3.0-dist' from 'daemon' Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:
Package is missing maintainers. got build log for '/nix/store/irg2a9x8i9rqm8mq48jbg6q8y0i8ciqv-python3.12-h5netcdf-1.3.0' from 'daemon' Near pkgs/development/python-modules/h5netcdf/default.nix:46:5:
Package is missing maintainers. got build log for '/nix/store/d2mv1hqmy8r9c2ysnl9vrkw1q7ahpfb4-python3.12-netcdf4-1.6.5-dist' from 'daemon' Near pkgs/development/python-modules/netcdf4/default.nix:73:5:
Package is missing maintainers. got build log for '/nix/store/0mv2ba9kvqnzmhycvmlxn9i4hdsn4w1s-python3.12-netcdf4-1.6.5' from 'daemon' Near pkgs/development/python-modules/netcdf4/default.nix:73:5:
Package is missing maintainers. got build log for '/nix/store/1czak465cz4hsr4q8avlipvi1nffzz0p-python3.12-python-mapnik-3.0.16-unstable-2024-02-22-dist' from 'daemon' Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:
Package is missing maintainers. got build log for '/nix/store/nyi30sjszm9l2d7m2w0zwfdjwl4wim4y-python3.12-python-mapnik-3.0.16-unstable-2024-02-22' from 'daemon' Near pkgs/development/python-modules/python-mapnik/default.nix:132:5:
got build log for '/nix/store/lmlpsvbzdgcj7sm5l70wn60brkbcvjs3-t-rex-0.15.0-alpha3' from 'daemon' Near pkgs/build-support/rust/build-rust-package/default.nix:135:3:
got build log for '/nix/store/l9w71cg465jamybpdmnx8lb9niqvr0zq-vpv-0.8.2' from 'daemon' Near pkgs/applications/graphics/vpv/default.nix:60:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md |
Thanks for running those reviews; my Linux laptop crashed before it finished with the review script 😅. I'm a bit surprised to see new failures introduced according to the Linux review pass; I wonder if that's possibly not the correct interpretation of those failures (they are new as of some previous Hydra run but not specifically introduced by this PR). |
Ok, I didn't check all of the 6 "new failures" but I did check the first two ( |
I can confirm that all packages, which fail here for |
I can also confirm that all packages marked as "new build failures" on |
Although this will cause a few rebuilds, it still isn't enough to warrant a |
I've put up a PR to hopefully address this in the netCDF |
Description of changes
As tracked upstream, later versions of
clang
produce warning that triggers failure when buildingnetcdf
. This PR introduces a tried and true strategy of ignoring those warnings for the time being -- many many projects are not as strict as the latestclang
versions would have them be.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.