Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: move elpaBuild together with other builders #330763

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Jul 29, 2024

Description of changes

This PR causes 0 rebuilds.

The 1 rebuild, x86_64-linux nixpkgs-manual, detected by ofborg is a false positive and is not relevant to this PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jian-lin jian-lin requested a review from AndersonTorres July 29, 2024 03:48
@jian-lin jian-lin requested a review from adisbladis as a code owner July 29, 2024 03:48
@github-actions github-actions bot added the 6.topic: emacs Text editor label Jul 29, 2024
@jian-lin jian-lin force-pushed the pr/move-elpaBuild branch from f68514f to 90d5b2d Compare July 29, 2024 03:54
@jian-lin jian-lin force-pushed the pr/move-elpaBuild branch from 90d5b2d to dfac396 Compare July 29, 2024 03:59
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 29, 2024
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 330763 run on x86_64-linux 1

1 package built:
  • nixpkgs-manual

Why is this nixpkgs-manual invoked?

@jian-lin
Copy link
Contributor Author

Why is this nixpkgs-manual invoked?

See #311459 (comment)

@adisbladis adisbladis merged commit a2e8968 into NixOS:master Jul 30, 2024
32 of 34 checks passed
@jian-lin jian-lin deleted the pr/move-elpaBuild branch July 30, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants