Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moc: 2.5.2 -> 2.6-alpha3-unstable-2019-09-14 #331634

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 1, 2024

Description of changes

Includes upstream fixes for FFmpeg 4(!), and downstream ones from Cygwin for FFmpeg 6 and 7.

If anyone really like this player, there are a bunch more patches here:

But you should maybe, like, fork it and apply all of these rather than having downstreams carry even more of them.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Includes upstream fixes for FFmpeg 4(!), and downstream ones from
Cygwin for FFmpeg 6 and 7.

If anyone really like this player, there are a bunch more patches here:

* <https://cygwin.com/cgit/cygwin-packages/moc/tree/>
* <https://salsa.debian.org/riesebie/moc/-/tree/master/debian/patches?ref_type=heads>

But you should maybe, like, fork it and apply all of these rather
than having downstreams carry even more of them.
@emilazy emilazy force-pushed the push-kuupnqnomklq branch from 51ec063 to 335d4f5 Compare August 9, 2024 22:00
@Mindavi Mindavi merged commit bfbf2d4 into NixOS:master Aug 10, 2024
26 of 27 checks passed
@emilazy emilazy mentioned this pull request Aug 21, 2024
13 tasks
@emilazy emilazy deleted the push-kuupnqnomklq branch August 26, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants