Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attract-mode: 2.6.2 -> 2.7.0-unstable-2024-08-02 #331636

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 1, 2024

Description of changes

Includes fixes for FFmpeg 7.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % the update to now-merged PR.

pkgs/by-name/at/attract-mode/package.nix Outdated Show resolved Hide resolved
@emilazy emilazy changed the title attract-mode: 2.6.2 -> 2.7.0-unstable-2024-06-21 attract-mode: 2.6.2 -> 2.7.0-unstable-2024-08-02 Aug 3, 2024
@emilazy emilazy force-pushed the push-lowxmspxtzxz branch from 7a5b8c4 to d2b1bf9 Compare August 3, 2024 17:54
@philiptaron
Copy link
Contributor

tidyf caught the dead code 👁️ 🗿 👁️!

@emilazy emilazy force-pushed the push-lowxmspxtzxz branch from d2b1bf9 to 2e7de3f Compare August 3, 2024 18:03
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philiptaron philiptaron merged commit f5d301a into NixOS:master Aug 3, 2024
25 of 27 checks passed
@emilazy emilazy mentioned this pull request Aug 21, 2024
13 tasks
@emilazy emilazy deleted the push-lowxmspxtzxz branch August 26, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants