Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libextractor: 1.11 -> 1.13 #332051

Merged
merged 1 commit into from
Aug 10, 2024
Merged

libextractor: 1.11 -> 1.13 #332051

merged 1 commit into from
Aug 10, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 3, 2024

Description of changes

Upstream dropped FFmpeg support, which is convenient for my current quest, as they were stuck on FFmpeg 4.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Upstream dropped FFmpeg support, which is convenient for my current
quest, as they were stuck on FFmpeg 4.
@donovanglover
Copy link
Member

Result of nixpkgs-review pr 332051 run on x86_64-linux 1

9 packages built:
  • challenger
  • doodle
  • gnunet
  • gnunet-gtk
  • libextractor
  • sync
  • taler-exchange
  • taler-merchant
  • vdrPlugins.xineliboutput

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donovanglover donovanglover requested a review from wegank August 9, 2024 19:56
@wegank
Copy link
Member

wegank commented Aug 10, 2024

Result of nixpkgs-review pr 332051 run on aarch64-darwin 1

1 package marked as broken and skipped:
  • gnunet-gtk
2 packages built:
  • gnunet
  • libextractor

@wegank wegank merged commit f85a800 into NixOS:master Aug 10, 2024
28 of 29 checks passed
@emilazy emilazy mentioned this pull request Aug 21, 2024
13 tasks
@emilazy emilazy deleted the push-suprwomxyvrm branch August 26, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants