Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portfolio: 0.69.1 -> 0.70.1 #332310

Closed
wants to merge 1 commit into from
Closed

Conversation

Shawn8901
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Shawn8901 Shawn8901 closed this Aug 4, 2024
@andresilva
Copy link
Member

Why did you close?

@Shawn8901
Copy link
Contributor Author

Portfolio seems to crash with the same reason as in #330889 . I initially thought it's related to updating. After reading further comments I saw that also older versions are already affected.
So I started to try to bisect what is causing the crash.
But haven't yet found time to fully went through.

Die to that I kept the PR closed as maybe someone else has time to take a look.

As the other issue was closed today, it might also be already solved (idk).
I can check later and reopen with 0.7.3 if it's working again.

@kilianar
Copy link
Contributor

kilianar commented Aug 8, 2024

I attempted to update portfolio to version 0.70.3 on top of the current master branch, but the issue still persists.

@Shawn8901 Shawn8901 deleted the update_portfolio branch August 11, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants