Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spidermonkey_128: init at 128.1.0 #333028

Merged
merged 2 commits into from
Aug 9, 2024
Merged

spidermonkey_128: init at 128.1.0 #333028

merged 2 commits into from
Aug 9, 2024

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Aug 7, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@bobby285271 bobby285271 mentioned this pull request Aug 7, 2024
Open
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 7, 2024
@ofborg ofborg bot requested review from catap, lostnet and abbradar August 7, 2024 17:33
@bobby285271 bobby285271 marked this pull request as ready for review August 8, 2024 16:01
@bobby285271 bobby285271 merged commit 3785c1d into NixOS:master Aug 9, 2024
35 of 39 checks passed
@bobby285271 bobby285271 deleted the add/mozjs128 branch August 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catap catap Awaiting requested review from catap

@lostnet lostnet Awaiting requested review from lostnet

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bobby285271