Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-es: 1.10.0 -> 2.0.0 #333611

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for protoc-gen-es is: Protobuf plugin for generating ECMAScript code

meta.homepage for protoc-gen-es is: https://github.com/bufbuild/protobuf-es

meta.changelog for protoc-gen-es is: https://github.com/bufbuild/protobuf-es/releases/tag/v2.0.0

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 2.0.0 with grep in /nix/store/d0iaqxr6pngjpx5w9rxyfszkq8k41a7a-protoc-gen-es-2.0.0
  • found 2.0.0 in filename of file in /nix/store/d0iaqxr6pngjpx5w9rxyfszkq8k41a7a-protoc-gen-es-2.0.0

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

protoc-gen-es
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/d0iaqxr6pngjpx5w9rxyfszkq8k41a7a-protoc-gen-es-2.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A protoc-gen-es https://github.com/r-ryantm/nixpkgs/archive/effee014bb0f8472d80199343989e1aca7bcaa68.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/effee014bb0f8472d80199343989e1aca7bcaa68#protoc-gen-es

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/d0iaqxr6pngjpx5w9rxyfszkq8k41a7a-protoc-gen-es-2.0.0
ls -la /nix/store/d0iaqxr6pngjpx5w9rxyfszkq8k41a7a-protoc-gen-es-2.0.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • protoc-gen-es

Maintainer pings

cc @felschr @jtszalay for testing.


Add a 👍 reaction to pull requests you find important.

@felschr
Copy link
Member

felschr commented Aug 10, 2024

The package still has the same runtime error as I've noted here #243432 (comment)

Looking into this issue a bit I found that the symlinks to @bufbuild/protoplugin & some other @bufbuild/ packages are broken:
/nix/store/d0iaqxr6pngjpx5w9rxyfszkq8k41a7a-protoc-gen-es-2.0.0/lib/node_modules/protobuf-es/node_modules/@bufbuild/

Not sure why this happens, for protoc-gen-connect-es those directories aren't empty and they also aren't symlinks.

Copy link
Member

@felschr felschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runtime issue would be solved with #333759.
Both the current version and this new version work once that fix is applied.
So essentially I'm good with merging this.

@felschr felschr added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Aug 10, 2024
@Mic92 Mic92 merged commit 3d56db6 into NixOS:master Aug 12, 2024
33 checks passed
@r-ryantm r-ryantm deleted the auto-update/protoc-gen-es branch August 12, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants