Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver-bin: add gtk3 as a runtime dependency #333918

Closed
wants to merge 1 commit into from

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Aug 11, 2024

Description of changes

Closes #330889.

Thanks @francisek for your research in #330889 (comment)!

Can you @spiage @gkze test whether dbeaver starts on this PR?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yzx9
Copy link
Contributor

yzx9 commented Aug 11, 2024

1 package built:
dbeaver-bin

Result of nixpkgs-review pr 333918 run on aarch64-darwin 1

1 package built:
  • dbeaver-bin

@spiage
Copy link

spiage commented Aug 11, 2024

After I switched my machine to inputs.nixpkgs.url = "github:nixos/nixpkgs/1d82f262cac3230bc9d7090bbd181863cc3a5f2f";
:(

❯ dbeaver 
WARNING: Using incubator modules: jdk.incubator.vector, jdk.incubator.foreign
Warning: NLS unused message: Workbench_missingPropertyMessage in: org.eclipse.ui.internal.messages
> Start Eclipse Jobs Mechanism [org.eclipse.core.jobs 3.15.300.v20240418-0734]
> Start Equinox Java Authentication and Authorization Service (JAAS) [org.eclipse.equinox.security 1.4.300.v20240419-2334]
> Start DBeaver Application Standalone [org.jkiss.dbeaver.ui.app.standalone 24.1.4.202408041450]
> Start Интерфейс приложения IDE Eclipse [org.eclipse.ui.ide.application 1.5.400.v20240416-0658]
SWT OS.java Error: Failed to load swt-pi3, loading swt-pi4 as fallback.
Dbeaver:
An error has occurred. See the log file
/home/spiage/.eclipse/191214826_linux_gtk_x86_64/configuration/1723412927473.log.

❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.10.3, NixOS, 24.11 (Vicuna), 24.11.20240811.1d82f26`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - channels(root): `""`
 - nixpkgs: `/nix/store/8ng6v5k35sw7jrckhfbm9dr4iaw1znaz-source`

@spiage
Copy link

spiage commented Aug 11, 2024

it worked for me with

❯ nix run github:nixos/nixpkgs/nixos-24.05#dbeaver-bin
WARNING: Using incubator modules: jdk.incubator.vector, jdk.incubator.foreign
Warning: NLS unused message: Workbench_missingPropertyMessage in: org.eclipse.ui.internal.messages
> Start Eclipse Jobs Mechanism [org.eclipse.core.jobs 3.15.300.v20240418-0734]
> Start Equinox Java Authentication and Authorization Service (JAAS) [org.eclipse.equinox.security 1.4.300.v20240419-2334]
> Start DBeaver Application Standalone [org.jkiss.dbeaver.ui.app.standalone 24.0.5.202405191503]
> Start Интерфейс приложения IDE Eclipse [org.eclipse.ui.ide.application 1.5.400.v20240416-0658]
> Start Eclipse IDE UI [org.eclipse.ui.ide 3.22.200.v20240424-0956]
> Start jna [com.sun.jna 5.14.0.v20231211-1200]
> Start DBeaver UI [org.jkiss.dbeaver.ui 5.1.146.202405191503]
> Start Expression Language [org.eclipse.core.expressions 3.9.400.v20240413-1529]
> Start DBeaver Usage Statistics [org.jkiss.dbeaver.ui.statistics 1.0.27.202405191503]
2024-08-12 01:08:27.329 - send collected statistics
> Start DBeaver Desktop Application Core [org.jkiss.dbeaver.core 24.0.5.202405191503]
2024-08-12 01:08:27.341 - DBeaver 24.0.5.202405191503 is starting
2024-08-12 01:08:27.342 - OS: Linux 6.10.3 (amd64)
2024-08-12 01:08:27.342 - Java version: 17.0.7 by N/A (64bit)
2024-08-12 01:08:27.342 - Install path: '/nix/store/qi3vvlia54sc762mqw06y22c1agkjxpj-dbeaver-bin-24.0.5/opt/dbeaver'
2024-08-12 01:08:27.342 - Instance path: 'file:/home/spiage/.local/share/DBeaverData/workspace6/'
2024-08-12 01:08:27.342 - Memory available 132Mb/1024Mb
2024-08-12 01:08:27.343 - Create display
2024-08-12 01:08:27.395 - Initialize desktop platform...
2024-08-12 01:08:27.439 - BounceCastle bundle found. Use JCE provider BC
> Start Core File Systems [org.eclipse.core.filesystem 1.10.400.v20240426-1040]

@spiage
Copy link

spiage commented Aug 11, 2024

and I have errors with:

❯ nix run github:nixos/nixpkgs/nixpkgs-unstable#dbeaver-bin
WARNING: Using incubator modules: jdk.incubator.foreign, jdk.incubator.vector
Warning: NLS unused message: Workbench_missingPropertyMessage in: org.eclipse.ui.internal.messages
> Start Eclipse Jobs Mechanism [org.eclipse.core.jobs 3.15.300.v20240418-0734]
> Start Equinox Java Authentication and Authorization Service (JAAS) [org.eclipse.equinox.security 1.4.300.v20240419-2334]
> Start DBeaver Application Standalone [org.jkiss.dbeaver.ui.app.standalone 24.1.4.202408041450]
> Start Интерфейс приложения IDE Eclipse [org.eclipse.ui.ide.application 1.5.400.v20240416-0658]
SWT OS.java Error: Failed to load swt-pi3, loading swt-pi4 as fallback.
Dbeaver:
An error has occurred. See the log file
/home/spiage/.eclipse/1486877750_linux_gtk_x86_64/configuration/1723414156495.log.

~ via  v3.12.4 via 💠 default 
❯ nix run github:nixos/nixpkgs/cbe511af766109cfedf2aa2d5076dba3b269336c#dbeaver-bin
WARNING: Using incubator modules: jdk.incubator.vector, jdk.incubator.foreign
Warning: NLS unused message: Workbench_missingPropertyMessage in: org.eclipse.ui.internal.messages
> Start Eclipse Jobs Mechanism [org.eclipse.core.jobs 3.15.300.v20240418-0734]
> Start Equinox Java Authentication and Authorization Service (JAAS) [org.eclipse.equinox.security 1.4.300.v20240419-2334]
> Start DBeaver Application Standalone [org.jkiss.dbeaver.ui.app.standalone 24.1.4.202408041450]
> Start Интерфейс приложения IDE Eclipse [org.eclipse.ui.ide.application 1.5.400.v20240416-0658]
SWT OS.java Error: Failed to load swt-pi3, loading swt-pi4 as fallback.
Dbeaver:
An error has occurred. See the log file
/home/spiage/.eclipse/1486877750_linux_gtk_x86_64/configuration/1723414171475.log.

~ via  v3.12.4 via 💠 default 
❯ nix run github:nixos/nixpkgs/1d82f262cac3230bc9d7090bbd181863cc3a5f2f#dbeaver-bin
WARNING: Using incubator modules: jdk.incubator.foreign, jdk.incubator.vector
Warning: NLS unused message: Workbench_missingPropertyMessage in: org.eclipse.ui.internal.messages
> Start Eclipse Jobs Mechanism [org.eclipse.core.jobs 3.15.300.v20240418-0734]
> Start Equinox Java Authentication and Authorization Service (JAAS) [org.eclipse.equinox.security 1.4.300.v20240419-2334]
> Start DBeaver Application Standalone [org.jkiss.dbeaver.ui.app.standalone 24.1.4.202408041450]
> Start Интерфейс приложения IDE Eclipse [org.eclipse.ui.ide.application 1.5.400.v20240416-0658]
SWT OS.java Error: Failed to load swt-pi3, loading swt-pi4 as fallback.
Dbeaver:
An error has occurred. See the log file
/home/spiage/.eclipse/191214826_linux_gtk_x86_64/configuration/1723414186311.log.

~ via  v3.12.4 via 💠 default 
❯ nix run github:nixos/nixpkgs/master#dbeaver-bin
WARNING: Using incubator modules: jdk.incubator.vector, jdk.incubator.foreign
Warning: NLS unused message: Workbench_missingPropertyMessage in: org.eclipse.ui.internal.messages
> Start Eclipse Jobs Mechanism [org.eclipse.core.jobs 3.15.300.v20240418-0734]
> Start Equinox Java Authentication and Authorization Service (JAAS) [org.eclipse.equinox.security 1.4.300.v20240419-2334]
> Start DBeaver Application Standalone [org.jkiss.dbeaver.ui.app.standalone 24.1.4.202408041450]
> Start Интерфейс приложения IDE Eclipse [org.eclipse.ui.ide.application 1.5.400.v20240416-0658]
SWT OS.java Error: Failed to load swt-pi3, loading swt-pi4 as fallback.
Dbeaver:
An error has occurred. See the log file
/home/spiage/.eclipse/1486877750_linux_gtk_x86_64/configuration/1723414208940.log.

@spiage
Copy link

spiage commented Aug 11, 2024

but it's still work with:

❯ nix run github:nixos/nixpkgs/4d10225ee46c0ab16332a2450b493e0277d1741a#dbeaver-bin
WARNING: Using incubator modules: jdk.incubator.foreign, jdk.incubator.vector
Warning: NLS unused message: Workbench_missingPropertyMessage in: org.eclipse.ui.internal.messages
> Start Eclipse Jobs Mechanism [org.eclipse.core.jobs 3.15.300.v20240418-0734]
> Start Equinox Java Authentication and Authorization Service (JAAS) [org.eclipse.equinox.security 1.4.300.v20240419-2334]
> Start DBeaver Application Standalone [org.jkiss.dbeaver.ui.app.standalone 24.1.3.202407211303]
> Start Интерфейс приложения IDE Eclipse [org.eclipse.ui.ide.application 1.5.400.v20240416-0658]
> Start Eclipse IDE UI [org.eclipse.ui.ide 3.22.200.v20240524-2010]
> Start jna [com.sun.jna 5.14.0.v20231211-1200]
> Start DBeaver UI [org.jkiss.dbeaver.ui 5.1.150.202407211303]
> Start Expression Language [org.eclipse.core.expressions 3.9.400.v20240413-1529]
> Start DBeaver Usage Statistics [org.jkiss.dbeaver.ui.statistics 1.0.31.202407211303]
> Start DBeaver Desktop Application Core [org.jkiss.dbeaver.core 24.1.3.202407211303]
2024-08-12 01:28:59.777 - DBeaver 24.1.3.202407211303 is starting
2024-08-12 01:28:59.777 - OS: Linux 6.10.4 (amd64)
2024-08-12 01:28:59.777 - Java version: 17.0.11 by N/A (64bit)
2024-08-12 01:28:59.777 - Install path: '/nix/store/pdbkjph8xsv3iq2rr1p6ww7vl1g1ajlk-dbeaver-bin-24.1.3/opt/dbeaver'
2024-08-12 01:28:59.777 - Instance path: 'file:/home/spiage/.local/share/DBeaverData/workspace6/'

@gepbird
Copy link
Contributor Author

gepbird commented Aug 11, 2024

@spiage thanks a lot for testing it, unfortunate that just adding gtk3 doesn't fix the issue. I'm closing this as I don't have ideas to make progress.

@gepbird gepbird closed this Aug 11, 2024
@gepbird gepbird deleted the dbeaver-add-gtk branch August 11, 2024 22:54
@spiage
Copy link

spiage commented Aug 11, 2024

could we ask Eclipse mainteiners for help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbeaver-bin fails to start in master branch
3 participants