Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bandwhich: fix build by manually updating time #334824

Merged
merged 1 commit into from
Aug 15, 2024
Merged

bandwhich: fix build by manually updating time #334824

merged 1 commit into from
Aug 15, 2024

Conversation

Philipp-M
Copy link
Member

Description of changes

See #332957 for more details, this is a "surgical" procedure by updating the dependencies in Cargo.lock directly and patching it. The patch of Cargo.lock should be removed, when there's a new version release of bandwhich

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from Br1ght0ne and figsoda August 15, 2024 11:16
@alyssais alyssais merged commit fd61e57 into NixOS:master Aug 15, 2024
28 of 30 checks passed
@alyssais alyssais mentioned this pull request Aug 15, 2024
Open
@dotlambda dotlambda mentioned this pull request Aug 16, 2024
Merged
13 tasks
Mic92 added a commit to Mic92/nixpkgs that referenced this pull request Aug 16, 2024
@Mic92
Revert "bandwhich: 0.22.2 -> 0.22.2-unstable-2024-08-13"
7f2b9c1 
This reverts commit f0c5d2f.

Turns out that this package has been already fixed in NixOS#334824
@Mic92 Mic92 mentioned this pull request Aug 16, 2024
Merged
13 tasks
@Mic92
Copy link
Member

Mic92 commented Aug 16, 2024

I also requested a new release: imsnif/bandwhich#422

@Philipp-M Philipp-M deleted the bandwhich-fix-build branch August 16, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@figsoda figsoda Awaiting requested review from figsoda

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Philipp-M @Mic92 @alyssais