Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepfilternet: 0.5.6 -> 0.5.6-unstable-2024-08-15, fix build #334835

Closed
wants to merge 1 commit into from

Conversation

Philipp-M
Copy link
Member

Description of changes

See #332957 for more details, this updates it to the current git version and the local Cargo.lock and patches it, because otherwise the build still breaks (because of other issues).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais
Copy link
Member

alyssais commented Aug 15, 2024

#334838 had a simpler approach — would it work?

cc @Mrmaxmeier

@Philipp-M
Copy link
Member Author

Sure, I'm indifferent with either solution (as long as it doesn't break :))

@@ -22,6 +22,10 @@ rustPlatform.buildRustPackage rec {
};
};

postPatch = ''
ln --force -s ${./Cargo.lock} Cargo.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ln --force -s ${./Cargo.lock} Cargo.lock
ln -fs ${./Cargo.lock} Cargo.lock

@SuperSandro2000
Copy link
Member

because otherwise the build still breaks (because of other issues).

What other issues?

@SuperSandro2000
Copy link
Member

Closing in favor of #334838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants