-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vfkit: init at 0.5.1 #334907
Merged
Merged
vfkit: init at 0.5.1 #334907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarcasticadmin
force-pushed
the
rh/1723670822
branch
from
August 15, 2024 17:25
df0d3e9
to
c35e349
Compare
sarcasticadmin
force-pushed
the
rh/1723670822
branch
from
August 15, 2024 17:29
c35e349
to
eeed74e
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Aug 15, 2024
micnncim
added a commit
to micnncim/nur
that referenced
this pull request
Sep 5, 2024
See NixOS/nixpkgs#305868 and NixOS/nixpkgs#334907 for more information. Signed-off-by: micnncim <micnncim@gmail.com>
micnncim
added a commit
to micnncim/nur
that referenced
this pull request
Sep 5, 2024
See NixOS/nixpkgs#305868 and NixOS/nixpkgs#334907 for more information. Signed-off-by: micnncim <micnncim@gmail.com>
micnncim
added a commit
to micnncim/nur
that referenced
this pull request
Sep 5, 2024
See NixOS/nixpkgs#305868 and NixOS/nixpkgs#334907 for more information. Signed-off-by: micnncim <micnncim@gmail.com>
Lassulus
approved these changes
Sep 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
backport release-24.05
Backport PR automatically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes: #306179 #305868
init
vfkit
using the prebuilt universal macOS binary from the upstream project (suggested in #306179 (comment)). This isn't ideal but it looks like there are existing issues gettingvfkit
to build. Recent attempt: #306438 This seems to be related to work that'sin-progress
for the macOS SDK in nixpkgs: #229210 I figure it's better to havevfkit
in nixpkgs and working withpodman
on macOS than for it to be broken until there's a better path forward.Additionally, I've add
vfkit
to the PATH forpodman
.prior to having
vfkit
:Running
podman
withvfkit
:Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.