Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wstunnel: 9.7.4 -> 10.0.1 #335185

Merged
merged 4 commits into from
Aug 28, 2024
Merged

wstunnel: 9.7.4 -> 10.0.1 #335185

merged 4 commits into from
Aug 28, 2024

Conversation

r-vdp
Copy link
Contributor

@r-vdp r-vdp commented Aug 16, 2024

Description of changes

I made an upstream PR for the patch, I hope to get that merged and released before we merge this.
erebe/wstunnel#334

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 16, 2024
@r-vdp r-vdp requested review from h7x4 and NeverBehave August 16, 2024 19:00
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Aug 16, 2024
@r-vdp r-vdp changed the title wstunnel: 9.7.4 -> 10.0.0 wstunnel: 9.7.4 -> 10.0.1 Aug 16, 2024
@r-vdp r-vdp marked this pull request as ready for review August 16, 2024 22:28
@ofborg ofborg bot requested a review from NeverBehave August 17, 2024 01:35
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the nixos tests, seem to be running fine. I also had a look at the upstream diff, and didn't find anything requiring changes to the module, so that seems fine too.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 20, 2024
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Aug 21, 2024
@flokli flokli merged commit c891213 into NixOS:master Aug 28, 2024
27 checks passed
@r-vdp r-vdp deleted the wstunnel-10_0_0 branch August 30, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants