Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pods: 2.0.0 -> 2.0.1-unstable-2024-08-11 #335565

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

DerRockWolf
Copy link
Contributor

@DerRockWolf DerRockWolf commented Aug 18, 2024

Description of changes

Updates pods to the newest commit to fix build failure caused by rust 1.80 (ref: #332957)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from figsoda August 18, 2024 10:33
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 18, 2024
@alyssais
Copy link
Member

Has upstream been asked for a release?

@DerRockWolf
Copy link
Contributor Author

DerRockWolf commented Aug 18, 2024

Has upstream been asked for a release?

Not yet, I'll ask them.
But considering that the latest release is from December last year, I see the changes kinda slim 🙈

Edit: I've opened marhkb/pods#797

@alyssais alyssais merged commit aac3500 into NixOS:master Aug 19, 2024
33 of 35 checks passed
@DerRockWolf DerRockWolf deleted the update/pods branch August 19, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants