Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsStatic.python312: fix build #335986

Merged
merged 1 commit into from
Aug 20, 2024
Merged

pkgsStatic.python312: fix build #335986

merged 1 commit into from
Aug 20, 2024

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Aug 20, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tobim tobim requested a review from natsukium as a code owner August 20, 2024 04:21
@tobim tobim mentioned this pull request Aug 20, 2024
Merged
13 tasks
philiptaron
philiptaron approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built pkgsStatic.python312, pkgsStatic.python311, pkgsStatic.python310, and pkgsStatic.python39 on x86_64-linux. All roses. 🌹

natsukium
natsukium reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also built fine on aarch64-linux.

closes #325302

@philiptaron philiptaron merged commit b9676b7 into NixOS:master Aug 20, 2024
21 checks passed
@t4ccer t4ccer mentioned this pull request Aug 20, 2024
Closed
@tobim tobim deleted the pkgs/python312-static branch August 21, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@philiptaron philiptaron philiptaron approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@natsukium natsukium natsukium approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tobim @philiptaron @dotlambda @SuperSandro2000 @natsukium