Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokei: 12.1.2 -> 13.0.0-alpha.4 #336118

Closed
wants to merge 4 commits into from
Closed

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nagy
Copy link
Member

nagy commented Aug 20, 2024

alpha2 has been released just recently.

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Aug 20, 2024

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 20, 2024
@tobim
Copy link
Contributor

tobim commented Aug 21, 2024

Result of nixpkgs-review pr 336118 run on x86_64-linux 1

2 packages built:
  • emacsPackages.tokei
  • tokei

Path handling seems to be broken:

> results/tokei/bin/tokei --exclude nixpkgs
thread 'main' panicked at /build/tokei-13.0.0-alpha.3-vendor.tar.gz/clap_builder/src/parser/error.rs:32:9:
Mismatch between definition and access of `exclude`. Could not downcast to TypeId { t: (13369810092395217272, 7199936582794304877) }, need to downcast to TypeId { t: (12860632812102975081, 3350365521333402252) }

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)

> results/tokei/bin/tokei logs
thread 'main' panicked at /build/tokei-13.0.0-alpha.3-vendor.tar.gz/clap_builder/src/parser/error.rs:32:9:
Mismatch between definition and access of `input`. Could not downcast to TypeId { t: (13369810092395217272, 7199936582794304877) }, need to downcast to TypeId { t: (12860632812102975081, 3350365521333402252) }

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)

@Sigmanificient Sigmanificient changed the title tokei: 12.1.2 -> 13.0.0-alpha.1 tokei: 12.1.2 -> 13.0.0-alpha.3 Aug 21, 2024
@Sigmanificient Sigmanificient changed the title tokei: 12.1.2 -> 13.0.0-alpha.3 tokei: 12.1.2 -> 13.0.0-alpha.4 Aug 22, 2024
@tobim
Copy link
Contributor

tobim commented Aug 23, 2024

Still broken: XAMPPRocky/tokei#1145 (comment).

@Sigmanificient
Copy link
Member Author

This cycle is never going to end 😄

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants