Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iamb: 0.0.9 -> 0.0.10 #336278

Merged
merged 1 commit into from
Aug 21, 2024
Merged

iamb: 0.0.9 -> 0.0.10 #336278

merged 1 commit into from
Aug 21, 2024

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Aug 21, 2024

Description of changes

Reference: #332957
Changes: ulyssa/iamb#333

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@meain
Copy link
Member

meain commented Aug 21, 2024

Result of nixpkgs-review pr 336278 run on aarch64-darwin 1

1 package failed to build:
  • iamb

iamb.log

@a-kenji
Copy link
Contributor Author

a-kenji commented Aug 21, 2024

Thank you for checking the darwin build!

Do you have an error message?

@a-kenji
Copy link
Contributor Author

a-kenji commented Aug 21, 2024

Thank you, could you check, if adding the cocoa framework fixed the issue?

@Lassulus
Copy link
Member

tested on darwin, seems to work

@SuperSandro2000 SuperSandro2000 merged commit 1eae685 into NixOS:master Aug 21, 2024
24 of 26 checks passed
@a-kenji a-kenji deleted the update-iamb branch August 21, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants