-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.scipy: 1.14.0 -> 1.14.1 #336290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use this opportunity to:
nativeBuildInputs
->build-system
propagatedBuildInputs
->dependencies
- remove the
with lib;
frommeta
- Organize the inputs in this style
Not mandatory, but as we don't touch this derivation too often it might be a good idea.
Good idea. Thanks :) Will merge when CI is mostly green. |
b72e14f
to
5ae9abc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I don't like this diff noise..
5ae9abc
to
34123fc
Compare
Can be merged when CI is green. |
Thanks for taking the time to double-check the changes :) |
BTW since I noticed you have an affinity to scientific Python packages, maybe you'd like to share your opinion on #327437 ? |
Sure, I will have a look later :) |
nukeReferences | ||
pythran | ||
pkg-config | ||
wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 (on the wheel removal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would just sort this alphabetically but we can keep it now that you done it :)
meson-python | ||
nukeReferences | ||
pythran | ||
pkg-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these belong in nativeBuildInputs
. Also, numpy
is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these belong in
nativeBuildInputs
. Also,numpy
is missing.
The existence and not identicallity of both nativeBuildInputs
and build-system
is new to me. I am still surprised that you require adding to build-system
packages that are already part of dependencies
. I also don't think enforcing this is worth it. I plan to open a discourse thread about these policies you started to enforce lately, and that we discussed in the related numpy/scipy threads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this didn't bump scipy to 1.14.1 after all. 🤷 |
Damn you are right! Thanks for commenting here, probably got lost in one of the rebases here. The real update is now in #351879 . |
Description of changes
Things done
nix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.