Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-desktop: 7.19.0 -> 7.21.0 #336379

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

jackwilsdon
Copy link
Contributor

@jackwilsdon jackwilsdon commented Aug 21, 2024

Description of changes

signalapp/Signal-Desktop@v7.21.0...v7.19.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Gliczy
Copy link
Member

Gliczy commented Aug 22, 2024

7.21.0 has been released https://github.com/signalapp/Signal-Desktop/releases/tag/v7.21.0

@jackwilsdon jackwilsdon changed the title signal-desktop: 7.19.0 -> 7.20.1 signal-desktop: 7.19.0 -> 7.21.0 Aug 22, 2024
@jackwilsdon
Copy link
Contributor Author

Updated 👍

Copy link
Member

@Gliczy Gliczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 336379 run on x86_64-linux 1

1 package built:
  • signal-desktop

I also did some basic testing.

@fabianhjr fabianhjr merged commit 87f0efc into NixOS:master Aug 23, 2024
33 of 35 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

@jackwilsdon jackwilsdon deleted the update-signal-desktop branch August 23, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants