cernlib: 2006 -> 2024.06.12.0 #336597
Merged
cernlib: 2006 -> 2024.06.12.0 #336597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of |
ofborg
bot
added
8.has: package (new)
|
@GrahamcOfBorg build cernlib |
|
Result of 1 package failed to build:
Errors: |
|
Yeah, I guess it is still broken on darwin. For me it doesn't give any error, instead runlib silently fails. |
|
It builds on Darwin applying this patch: geant321-fix-weak-alias-on-darwin.patch But then: $ realpath ./result
/nix/store/37idfl6144dsrlvg27fhdi67cj1dp35m-cernlib-2024.06.12.0
$ ./result/bin/cernlib
Can't find CERNLIB libraries in /nix/store/37idfl6144dsrlvg27fhdi67cj1dp35m-cernlib-2024.06.12.0/lib/cernlib/2024!
$ ./result/bin/cernlib-static
/nix/store/37idfl6144dsrlvg27fhdi67cj1dp35m-cernlib-2024.06.12.0/lib/cernlib/2024/lib/libpacklib.aThis output is pointing to non-existing path (And no shared libs?) |
|
@smancill I've included your patch. Would you mind sending it to Ulrich and Andrii https://arxiv.org/abs/2303.07506 so that it can be included in the next GPL version? |
|
Regarding the shared libraries, we don't build them on Linux either. We could enable it later, if there is a use case. |
|
Result of 1 package built:
|
I could do that on the next days. But there seem to be still some issues: |
|
I think one needs some correct CERN and CERN_LEVEL to make those shell wrappers work. I'm not sure why, but the directory structure does not have any structure to support CERN_LEVEL, I don't know why. |
Looks like one needs to disable hardening. edit: that doesn't help |
|
I think, this is okay to merge as-is. I assume, the actual libraries just still work, and, hopefully, this will alleviate some maintenance burden. To work on the binaries one needs to have more experience with cernlib to be productive about that. |
Yes, I agree. And it builds on Linux and Darwin. I was just blindly trying to run binaries to see if the patch for Darwin was working on runtime. |
smancill
approved these changes
Sep 6, 2024
wegank
added
the
12.approvals: 1
|
I've checked, the fatsrv has the same problem in the current cernlib-2006, and paw-X11 is not even present there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update to a maintained version.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.