Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "python3.apt: init at 2.8.0" #337041

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

alyssais
Copy link
Member

Description of changes

This reverts commit ec0b212.

This is a duplicate of the existing python3Packages.python-apt, and introducing it broke eval of that package (because now "apt" in the Python package set doesn't refer to pkgs.apt, as that package expects).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This reverts commit ec0b212.

This is a duplicate of the existing python3Packages.python-apt, and
introducing it broke eval of that package (because now "apt" in the
Python package set doesn't refer to pkgs.apt, as that package
expects).
@alyssais alyssais requested a review from nbraud August 24, 2024 16:15
@alyssais alyssais requested a review from natsukium as a code owner August 24, 2024 16:15
@alyssais alyssais mentioned this pull request Aug 24, 2024
13 tasks
@alyssais alyssais requested a review from mkg20001 August 24, 2024 16:15
@alyssais
Copy link
Member Author

No point waiting for OfBorg here — it can't pass while the base branch is broken..

@alyssais alyssais merged commit 784f66e into NixOS:master Aug 24, 2024
8 of 9 checks passed
@alyssais alyssais deleted the apt-revert branch August 24, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant