avrdude: 7.3 -> 8.0 #337100
Merged
avrdude: 7.3 -> 8.0 #337100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkeleinhorn
requested review from
philiptaron and
nagy
and removed request for
philiptaron
bjornfor
approved these changes
Aug 25, 2024
philiptaron
reviewed
Aug 26, 2024
| rev = "v${finalAttrs.version}"; | ||
| sha256 = "sha256-JqW3AOMmAfcy+PQRcqviWlxA6GoMSEfzIFt1pRYY7Dw="; | ||
| sha256 = "w58HVCvKuWpGJwllupbj7ndeq4iE9LPs/IjFSUN0DOU="; |
There was a problem hiding this comment.
Please use an SRI hash here:
hash = "sha256-w58HVCvKuWpGJwllupbj7ndeq4iE9LPs/IjFSUN0DOU=";
There was a problem hiding this comment.
Will change this at the beginning of next week as I am on holiday right now.
There was a problem hiding this comment.
Ok. I plan to merge tonight, as I think sha256 vs hash is orthogonal to the version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Release notes: https://github.com/avrdudes/avrdude/blob/4fa07e563fbe7ce0fa3c467eff20fc9e04de5298/NEWS
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.