Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: fix libv8 object files list #337360

Merged
merged 1 commit into from
Sep 2, 2024
Merged

nodejs: fix libv8 object files list #337360

merged 1 commit into from
Sep 2, 2024

Conversation

tie
Copy link
Member

@tie tie commented Aug 25, 2024

Description of changes

See #327653 (comment)

Well, we have an outdated v8 package in Nixpkgs and #147506 introduced a libv8 output for Node.js package with v8 static library.

[…] looks like I’ve missed that these object files are actually under completely different paths when built with Ninja (line 349 in particular does not match any files).

Manually verified with ar t that nodejs_20.libv8 has the same list of object files as before and tested with

nix build --file . postgresql.pkgs.plv8.tests.smoke

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this fixed postgresql.pkgs.plv8.tests for me.

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But I'm not a nodejs maintainer, so I'll refrain from merging until a nodejs maintainer has taken a look at this.

@Ma27 Ma27 merged commit efbf70d into NixOS:staging Sep 2, 2024
39 of 40 checks passed
@tie tie deleted the pg-nodejs-libv8 branch September 2, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants