-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mqttx-cli: init at 1.11.0 #337730
mqttx-cli: init at 1.11.0 #337730
Conversation
08cd92a
to
a310cc0
Compare
added version test |
I just realized that the binary name conflicts with mqttx desktop app. |
Looking at other repos such as AUR, they don't seem to have mqttx-cli in them.
The first option does not seem good because I can see some users wanting both packages at the same time. The second option seems good IMO but is a breaking change for the users currently using MQTTX desktop app. The third option seems to be the easiest. I'll change this cli app name to |
a310cc0
to
f5a59bb
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4589 |
f5a59bb
to
b6a8ac5
Compare
Updated package to 1.11.0 and fixed the update script |
b6a8ac5
to
438b40e
Compare
438b40e
to
6b52b6a
Compare
6b52b6a
to
2b71ca9
Compare
]; | ||
|
||
preConfigure = '' | ||
cd cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd cli | |
export HOME="$(mktemp -d)" | |
cd cli |
Might fix the build failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to reproduce the build failure on my x86_64-darwin machine...
I know that hydra is using rosetta on aarch64-darwin to build x86_64-darwin packages, so it may be an issue with that. I will try building it on an aarch64-darwin machine when I have the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you rebase the PR on master before building? (that is almost what ofborg does)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran nixpkgs-review on a x86_64-darwin machine.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 337730
x86_64-darwin
✅ 1 package built:
- mqttx-cli
@ofborg build mqttx-cli We can always try again |
Description of changes
Adds mqttx-cli package.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.