Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqttx-cli: init at 1.11.0 #337730

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

pineapplehunter
Copy link
Contributor

@pineapplehunter pineapplehunter commented Aug 27, 2024

Description of changes

Adds mqttx-cli package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pineapplehunter pineapplehunter force-pushed the mqttx-cli branch 3 times, most recently from 08cd92a to a310cc0 Compare August 28, 2024 06:26
@pineapplehunter
Copy link
Contributor Author

added version test

@pineapplehunter
Copy link
Contributor Author

I just realized that the binary name conflicts with mqttx desktop app.
I'll check what others are doing in this case.

@pineapplehunter
Copy link
Contributor Author

Looking at other repos such as AUR, they don't seem to have mqttx-cli in them.
I can think of three solutions to the conflicting binary name problem.

  1. Let the user install only one package
  2. Change the desktop app binary to mqttx-desktop or something similar
  3. Change the cli app binary to mqtttx-cli or something similar

The first option does not seem good because I can see some users wanting both packages at the same time. The second option seems good IMO but is a breaking change for the users currently using MQTTX desktop app. The third option seems to be the easiest.

I'll change this cli app name to mqttx-cli for now.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4589

@pineapplehunter pineapplehunter changed the title mqttx-cli: init at 1.10.1 mqttx-cli: init at 1.11.0 Oct 29, 2024
@pineapplehunter
Copy link
Contributor Author

Updated package to 1.11.0 and fixed the update script

];

preConfigure = ''
cd cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd cli
export HOME="$(mktemp -d)"
cd cli

Might fix the build failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to reproduce the build failure on my x86_64-darwin machine...
I know that hydra is using rosetta on aarch64-darwin to build x86_64-darwin packages, so it may be an issue with that. I will try building it on an aarch64-darwin machine when I have the time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you rebase the PR on master before building? (that is almost what ofborg does)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran nixpkgs-review on a x86_64-darwin machine.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 337730


x86_64-darwin

✅ 1 package built:
  • mqttx-cli

@FliegendeWurst
Copy link
Member

@ofborg build mqttx-cli

We can always try again

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@FliegendeWurst FliegendeWurst merged commit db0a6c2 into NixOS:master Dec 20, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants