nixos/etc-overlay: avoid rebuilding the initrd every time the etc contents change #340722
+110
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg test activation-etc-overlay-mutable activation-etc-overlay-immutable |
r-vdp
commented
Sep 9, 2024
r-vdp
commented
Sep 9, 2024
r-vdp
force-pushed
the
etc-overlay-no-initrd-rebuilds
branch
from
6c6e66d
to
08f7609
Compare
|
@nikstur would you be able to give this a review? I think it would be nice to get this in before 24.11 branch-off. |
r-vdp
force-pushed
the
etc-overlay-no-initrd-rebuilds
branch
from
08f7609
to
fd801cf
Compare
r-vdp
changed the title
nikstur
reviewed
Oct 9, 2024
… separate service
r-vdp
force-pushed
the
etc-overlay-no-initrd-rebuilds
branch
from
fd801cf
to
36488c1
Compare
r-vdp
force-pushed
the
etc-overlay-no-initrd-rebuilds
branch
2 times, most recently
from
2ca1a21
to
70dc0a1
Compare
|
@ofborg test activation-etc-overlay-mutable activation-etc-overlay-immutable systemd-initrd-simple |
…tents change Before this change, the hash of the etc metadata image was included in the mount unit that's responsible for mounting this metadata image in the initrd. And because this metadata image changes with every change to the etc contents, the initrd would be rebuild every time as well. This can lead to a lot of rebuilds (especially when revision info is included in /etc/os-release) and all these initrd archives use up a lot of space on the ESP. With this change, we instead include a symlink to the metadata image in the top-level directory, in the same way as we already do for things like init and prepare-root, and we deduce the store path from the init= kernel parameter, in the same way as we already do to find the path to init and prepare-root. Doing so avoids rebuilding the initrd all the time.
r-vdp
force-pushed
the
etc-overlay-no-initrd-rebuilds
branch
from
70dc0a1
to
792fd17
Compare
|
@ofborg test activation-etc-overlay-mutable activation-etc-overlay-immutable systemd-initrd-simple |
fpletz
approved these changes
Oct 10, 2024
|
Also tested the reboot now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Before this change, the hash of the etc metadata image was included in the mount unit that's responsible for mounting this metadata image in the initrd.
And because this metadata image changes with every change to the etc contents, the initrd would be rebuilt every time as well.
This can lead to a lot of rebuilds (especially when revision info is included in /etc/os-release) and all these initrd archives use up a lot of space on the ESP.
With this change, we instead include a symlink to the metadata image in the top-level directory, in the same way as we already do for things like init and prepare-root, and we deduce the store path from the init= kernel parameter, in the same way as we already do to find the path to init and prepare-root.
Doing so avoids rebuilding the initrd all the time.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.