Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-tools: 1.216.0 -> 1.217.0 #341059

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

ereslibre
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao
Copy link
Member

NickCao commented Sep 11, 2024

Test failure on aarch64-linux.

@ereslibre
Copy link
Member Author

ereslibre commented Sep 11, 2024

I tried to reproduce and I found a similar error on another test (on aarch64-linux too):

failures:

---- "tests/cli/wit-directory-output-in-deps-folder-with-multiple-version.wit" ----
failed test "tests/cli/wit-directory-output-in-deps-folder-with-multiple-version.wit"

Caused by:
    Broken pipe (os error 32)

---- "tests/cli/wit-directory-output-valid.wit" ----
failed test "tests/cli/wit-directory-output-valid.wit"

Caused by:
    Broken pipe (os error 32)


failures:
    "tests/cli/wit-directory-output-in-deps-folder-with-multiple-version.wit"
    "tests/cli/wit-directory-output-valid.wit"

test result: FAILED. 104 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s

error: test failed, to rerun pass `-p wasm-tools --test cli`
error: builder for '/nix/store/8giijrm17iphm9hyrwf6vxm0n6cg5rdq-wasm-tools-1.217.0.drv' failed with exit code 101;
       last 10 log lines:
       >     Broken pipe (os error 32)
       >
       >
       > failures:
       >     "tests/cli/wit-directory-output-in-deps-folder-with-multiple-version.wit"
       >     "tests/cli/wit-directory-output-valid.wit"
       >
       > test result: FAILED. 104 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s
       >
       > error: test failed, to rerun pass `-p wasm-tools --test cli`
       For full logs, run 'nix log /nix/store/8giijrm17iphm9hyrwf6vxm0n6cg5rdq-wasm-tools-1.217.0.drv'.

If I find the time, I'll have a look at what's going on.

@ereslibre
Copy link
Member Author

I have submitted bytecodealliance/wasm-tools#1820 to keep track of this issue. I'm going to update the flags so that we force --test-threads=1 for now.

@ereslibre
Copy link
Member Author

Updated the PR to set test threads to 1 for aarch64. I was not able to reproduce the issue with this setting.

@NickCao NickCao merged commit a8566c8 into NixOS:master Sep 27, 2024
25 of 26 checks passed
@ereslibre ereslibre deleted the bump-wasm-tools branch September 27, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants