python312Packages.plotly: 5.23.0 -> 5.24.0 and some TLC #341141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 8 packages marked as broken and skipped:
3 packages failed to build:
115 packages built:
|
|
Both |
|
Result of 10 packages marked as broken and skipped:
118 packages built:
|
|
If you want to enable the checkPhase, please make sure it actually runs the tests. I enabled pytest and ran through a couple of the errors, but there are lots more to figure out :) diff --git a/pkgs/development/python-modules/plotly/default.nix b/pkgs/development/python-modules/plotly/default.nix
index 0ca2cc6c08a0..e94ce037258c 100644
--- a/pkgs/development/python-modules/plotly/default.nix
+++ b/pkgs/development/python-modules/plotly/default.nix
@@ -6,6 +6,20 @@
packaging,
tenacity,
kaleido,
+ pytestCheckHook,
+ pandas,
+ requests,
+ matplotlib,
+ xarray,
+ pillow,
+ scipy,
+ psutil,
+ statsmodels,
+ ipython,
+ which,
+ orca,
+ nbformat,
+ scikit-image,
}:
buildPythonPackage rec {
@@ -20,9 +34,9 @@ buildPythonPackage rec {
hash = "sha256-frSUybQxst4wG8g8U43Nay9dYCUXuR3dBealwPVyFdI=";
};
- postPatch = ''
- cd packages/python/plotly
+ sourceRoot = "${src.name}/packages/python/plotly";
+ postPatch = ''
substituteInPlace pyproject.toml \
--replace-fail "\"jupyterlab~=3.0;python_version>='3.6'\"," ""
'';
@@ -37,6 +51,23 @@ buildPythonPackage rec {
kaleido
];
+ nativeCheckInputs = [
+ pytestCheckHook
+ pandas
+ requests
+ matplotlib
+ xarray
+ pillow
+ scipy
+ psutil
+ statsmodels
+ ipython
+ which
+ orca
+ nbformat
+ scikit-image
+ ];
+
pythonImportsCheck = [ "plotly" ];
meta = { |
|
I enabled |
|
please review #347567
pythonImportsCheckHook is gated by doInstallCheck. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.