Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

immersed-vr: rename to immersed #341266

Merged
merged 2 commits into from
Oct 10, 2024
Merged

immersed-vr: rename to immersed #341266

merged 2 commits into from
Oct 10, 2024

Conversation

Pandapip1
Copy link
Contributor

Description of changes

See repology/repology-rules#851 for rationale

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 11, 2024
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Sep 12, 2024
@ofborg ofborg bot requested a review from haruki7049 September 12, 2024 07:52
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Sep 12, 2024
@haruki7049
Copy link
Contributor

Are you saying that only the immersed-vr package in nixpkgs is not named immersed compared to other package managers?

@Pandapip1
Copy link
Contributor Author

Are you saying that only the immersed-vr package in nixpkgs is not named immersed compared to other package managers?

As far as I know, there's only one other package manager that has packaged it, but its name is arguably more correct, as upstream doesn't use the -vr suffix and there is no conflict with other packages.

@haruki7049
Copy link
Contributor

Understood. Sure, we should match the naming of other package managers.

haruki7049
haruki7049 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@haruki7049 haruki7049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 13, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1952

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@Pandapip1 Pandapip1 force-pushed the rename-immersed-vr-to-immersed branch from ac12f61 to ab5706b Compare October 8, 2024 18:39
@Pandapip1
Copy link
Contributor Author

Rebased to fix merge conflict.

@Pandapip1 Pandapip1 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 8, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2023

@ofborg ofborg bot requested a review from haruki7049 October 8, 2024 19:52
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 9, 2024
@fpletz fpletz merged commit 9958dd2 into NixOS:master Oct 10, 2024
23 checks passed
@Pandapip1 Pandapip1 deleted the rename-immersed-vr-to-immersed branch October 10, 2024 14:51
@haruki7049 haruki7049 mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@haruki7049 haruki7049 Awaiting requested review from haruki7049

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pandapip1 @haruki7049 @nixos-discourse @fpletz @Aleksanaa @wegank