Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rippled: drop dead package.nix file #342054

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Sep 15, 2024

Description of changes

rippled's package.nix file is dead code (not referred to by anything else in rippled/) and contains a number of false positives when searching for packages still using SHA-1.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all affected packages using nixpkgs-review
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This came up while searching nixpkgs for SHA-1 hashes.
@nbraud
Copy link
Contributor Author

nbraud commented Sep 15, 2024

Result of nixpkgs-review pr 342054 run on aarch64-darwin 1

@nbraud
Copy link
Contributor Author

nbraud commented Sep 15, 2024

BTW, @offlinehacker @RaghavSood, are you still maintaining this package?

@nbraud
Copy link
Contributor Author

nbraud commented Sep 15, 2024

Result of nixpkgs-review pr 342054 run on x86_64-linux 1

@nbraud nbraud marked this pull request as ready for review September 15, 2024 12:30
@nbraud nbraud merged commit 24caa79 into NixOS:master Sep 17, 2024
26 of 27 checks passed
@nbraud nbraud deleted the shan1-use/rippled branch September 17, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant