gramma: remove mkYarnPackage usage #342145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tracking issue: #324246
Unfortunately,
yarnInstallHook
usesnodejsInstallExecutables
which usesmakeWrapper
to link the.js
files to$out/bin
whereasmkYarnPackage
uses symlinks.Symlinks work just fine, however
makeWrapper
messes with the cli tool so that it doesn't recognize that the binary name isn'tcli.js
.We could avoid this by just replacing the
makeWrapper
-ed executable with a symlink to the same place or we could patch the source to always usegramma
when displaying the binary name.I went with the latter, though the other solution is pretty easy too.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.